-
Notifications
You must be signed in to change notification settings - Fork 851
DB semantic convention stability migration for DB-API and 7 inheriting db client instrumentors #4109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
DB semantic convention stability migration for DB-API and 7 inheriting db client instrumentors #4109
Conversation
| try: | ||
| result[key] = int(value) | ||
| except ValueError: | ||
| except (ValueError, TypeError): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why A failure started happening in this PR instead of in #4108 with tox -e py3*-test-opentelemetry-instrumentation-aiopg because of aiopg instrumentor dependency on this. Example run with error:
TypeError: int() argument must be a string, a bytes-like object or a real number, not 'Mock'
Description
Add DB-API instrumentor support for when
OTEL_SEMCONV_STABILITY_OPT_INincludes "database" or "database/dup".This changes the
SQLComment in span attributefeature if opted in. Inclusion of sqlcomment on query span would be ondb.statementand/ordb.query.textattribute if default, "database", or "database/dup".These instrumentors inherit DB-API's
wrap_connectand/orinstrument_connection, and therefore also gain support for semconv migration automatically:Fixes #2929 #2678 #2928 #2931 #2932 #2933 #2934
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.