Skip to content

Conversation

@MeggyCal
Copy link

@MeggyCal MeggyCal commented Jan 5, 2026

Description

Wrapt 2 introduced some changes in object wrappers (this blog summarizes it nicely).

This change at least allows tests to pass with wrapt 2.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

I ran the testsuite of opentelemetry-instrumentation.

Does This PR Require a Core Repo Change?

  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Unit tests have been added

@MeggyCal MeggyCal requested a review from a team as a code owner January 5, 2026 10:40
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jan 5, 2026

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: MeggyCal / name: Markéta Machová (e9903c5)
  • ✅ login: MeggyCal / name: MeggyCal (20d63ce)

@JWinermaSplunk
Copy link

I am unsure about the necessity of this PR unless there are plans to update the version of wrapt, do we have any plans to use the new functionality from the major version? In turn, I am not sure allowing all versions of wrapt, i.e. "wrapt >= 1.0.0" would be the best idea. I think updating the major version of the dependency would classify the PR as a Breaking Change and not a New Feature. The PR also may require a changelog entry.

@xrmx xrmx moved this to Easy to review / merge / close in @xrmx's Python PR digest Jan 13, 2026
@xrmx
Copy link
Contributor

xrmx commented Jan 13, 2026

I'm not worried on permitting a newer wrapt version but I'm worried that:

  • we are not testing with a newer wrapt
  • we have instrumentations that make use of the object proxy that we have not changed to allow newer wrapt and we should to them at the same time to avoid incompatibilities between different packages

@xrmx xrmx moved this from Easy to review / merge / close to Reviewed PRs that need fixes in @xrmx's Python PR digest Jan 13, 2026
@blarghmatey
Copy link

Having Wrapt hard locked to <2 is a blocking bug for me to be able to use OpenTelemetry at all in one of my critical applications. That application is using Wrapt 2 and that means I can't even install this package to be able to instrument the application. The application in question is https://github.com/openedx/openedx-platform

@MeggyCal
Copy link
Author

Hi, I agree it would be nice to test this PR with wrapt 2 in several usecases. Sadly, I have almost no experience with automatic testing on GitHub, could someone please do it for me?

This PR still preserves compatibility with wrapt 1, so I don't see why it would be breaking, unless there are more problems with wrapt 2. I agree changelog entry would be nice to have, I will try to add it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Reviewed PRs that need fixes

Development

Successfully merging this pull request may close these issues.

4 participants