-
Notifications
You must be signed in to change notification settings - Fork 851
feat: update xray trace id generator for 'random-trace-id' flags changes #4030
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
xrmx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit confused, the title and CHANGELOG mention only xray but you're touching another half dozen instrumentations
I can update the title to be more descriptive. Essentially the main PR in the SDK repo adds the random trace id to the trace state section of the trace parent header. However, as a result of these changes, many unit tests broke in this repo since there were several instances where tests would hardcode the expected tracestate header, so a large portion of these changes are just fixing those tests to properly check the trace parent header. These changes are only unit test changes, so I didn't think it was worth mentioning in the changelog entry, but I can certainly modify this. The only "real" changes in this PR are updating the Xray trace id generator to override the |
e469f8f to
4b5e97d
Compare
|
@jj22ee could you please take a look at the opentelemetry-sdk-extension-aws changes? |
4b5e97d to
72b579e
Compare
Description
Updates
AwsXRayIdGeneratorto defineis_trace_id_random()to returnTrueand update unit tests for core changes to add support for populating therandom-trace-idflags in the W3C traceparent header based on the W3C trace context specification: https://www.w3.org/TR/trace-context-2/#random-trace-id-flagType of change
Please delete options that are not relevant.
How Has This Been Tested?
Unit tests have been updated to handle additional header flag.
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.