Skip to content

ci: Update postUpdateOptions for go - #2558

Open
thompson-tomo wants to merge 1 commit into
open-telemetry:mainfrom
thompson-tomo:go-mody-options
Open

ci: Update postUpdateOptions for go#2558
thompson-tomo wants to merge 1 commit into
open-telemetry:mainfrom
thompson-tomo:go-mody-options

Conversation

@thompson-tomo

Copy link
Copy Markdown
Contributor

This adjusts the go update options to tidy all files with the -e option and enables import path updates. This combination should reduce how much is being updated via the custom Workflow.

@wpessers

Copy link
Copy Markdown
Member

You suggest closing #2546 then @thompson-tomo in favour of this one? Just to be clear, do we now know for sure this will stop that looping behaviour from being triggered? Or will we still often rely on human intervention (setting the stop-updating label)?

@thompson-tomo

Copy link
Copy Markdown
Contributor Author

@wpessers what i am inclined to do is get this in and monitor how it behaves. For instance does it reduce the diff generated by the custom go mod tidy, does it resolve lockfile or is it still an issue.

I don't know for sure it will resolve but i expect it to improve the situation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants