docs: clarify View attribute filtering interaction with Exemplars#8419
Merged
jack-berg merged 3 commits intoMay 22, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8419 +/- ##
============================================
- Coverage 91.14% 91.14% -0.01%
- Complexity 7761 7762 +1
============================================
Files 881 881
Lines 23409 23409
Branches 2331 2331
============================================
- Hits 21337 21336 -1
Misses 1377 1377
- Partials 695 696 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
psx95
reviewed
May 21, 2026
| /** | ||
| * Sets a filter which retains attribute keys included in {@code keysToRetain}. | ||
| * | ||
| * <p><b>Note:</b> Attributes dropped by this filter may still appear on recorded exemplars. If |
Contributor
There was a problem hiding this comment.
Nit: The bold text tag <b> can be removed for 'Note:'.
Comment on lines
+20
to
+23
| * <p><b>Note:</b> When a view filters out attributes, the dropped attributes may still appear on | ||
| * recorded exemplars. If you need to remove sensitive data from exemplars, you must configure a | ||
| * custom {@link ExemplarFilter} or disable exemplars entirely. | ||
| * |
Contributor
There was a problem hiding this comment.
IMO, this could be removed from here. This documentation explains special behavior of setAttributeFilter method and is already part of method's Javadoc, so adding it to the class' Javadoc does not seem necessary.
psx95
approved these changes
May 21, 2026
jack-berg
reviewed
May 21, 2026
Contributor
Author
|
Thanks for the clarification @jack-berg! Updated the Javadoc to reflect the actual options (disable exemplars, delegating exporter, or Collector filtering). Let me know if it looks good 👍 |
zeitlinger
approved these changes
May 22, 2026
jack-berg
approved these changes
May 22, 2026
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #8391
Changes
Adds Javadoc notices to
ViewandViewBuilder.setAttributeFiltermethods, clarifying that attributes filtered out by a View may still appear on recorded exemplars.This behavior is non-obvious (measurement attributes are retained on Exemplars even if filtered by View/aggregation) and was resolved in the spec (#5073) and documented similarly in .NET (#7270).
Checklist