Replace ArrayBlockingQueue with park/unpark for BatchSpanProcessor$Worker#8240
Open
Khepu wants to merge 4 commits intoopen-telemetry:mainfrom
Open
Replace ArrayBlockingQueue with park/unpark for BatchSpanProcessor$Worker#8240Khepu wants to merge 4 commits intoopen-telemetry:mainfrom
Khepu wants to merge 4 commits intoopen-telemetry:mainfrom
Conversation
Bypassing all the complexity that comes with ABQ should come with improved performance
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8240 +/- ##
============================================
- Coverage 90.32% 90.32% -0.01%
+ Complexity 7654 7653 -1
============================================
Files 843 843
Lines 23080 23076 -4
Branches 2312 2312
============================================
- Hits 20848 20843 -5
+ Misses 1516 1514 -2
- Partials 716 719 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Making the worker extend thread was the only sensible way of having it keep a constant reference to its thread. Everything else I tried was quite hacky
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Browsing through the codebase I saw the ArrayBlockingQueue and thought I could do something better. Running benchmarks locally did produce better results though they weren't as consistent as I would have liked.
The same changes could also be applied to
BatchLogRecordProcessor.