Skip to content

Remove unchecked warning #8090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
trask wants to merge 1 commit into
base: main
Choose a base branch
from
+18 −19
Open

Remove unchecked warning #8090

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 18 additions & 19 deletions .../io/opentelemetry/sdk/extension/incubator/fileconfig/YamlDeclarativeConfigProperties.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,6 @@ public Double getDouble(String name) {

@Nullable
@Override
@SuppressWarnings("unchecked")
public <T> List<T> getScalarList(String name, Class<T> scalarType) {
if (!SUPPORTED_SCALAR_TYPES.contains(scalarType)) {
throw new DeclarativeConfigException(
Expand All @@ -208,28 +207,28 @@ public <T> List<T> getScalarList(String name, Class<T> scalarType) {
}
Object value = simpleEntries.get(name);
if (value instanceof List) {
List<Object> objectList = ((List<Object>) value);
List<?> objectList = (List<?>) value;
if (objectList.isEmpty()) {
return Collections.emptyList();
}
List<T> result =
(List<T>)
objectList.stream()
.map(
entry -> {
if (scalarType == String.class) {
return stringOrNull(entry, name);
} else if (scalarType == Boolean.class) {
return booleanOrNull(entry, name);
} else if (scalarType == Long.class) {
return longOrNull(entry, name);
} else if (scalarType == Double.class) {
return doubleOrNull(entry, name);
}
return null;
})
.filter(Objects::nonNull)
.collect(toList());
objectList.stream()
.map(
entry -> {
if (scalarType == String.class) {
return stringOrNull(entry, name);
} else if (scalarType == Boolean.class) {
return booleanOrNull(entry, name);
} else if (scalarType == Long.class) {
return longOrNull(entry, name);
} else if (scalarType == Double.class) {
return doubleOrNull(entry, name);
}
return null;
})
.filter(Objects::nonNull)
.map(scalarType::cast)
.collect(toList());
if (result.isEmpty()) {
return null;
}
Expand Down
Loading