Skip to content

Deprecate peerServiceMapping #8088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
trask wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −0
Open

Deprecate peerServiceMapping #8088

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ...ubator/src/main/java/io/opentelemetry/api/incubator/config/InstrumentationConfigUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,11 @@ public class InstrumentationConfigUtil {
* .instrumentation.general.peer.service_mapping}, or null if none is configured.
*
* @throws DeclarativeConfigException if an unexpected type is encountered accessing the property
* @deprecated Peer service mapping was removed from the general instrumentation configuration
* schema. See <a
* href="https://github.com/open-telemetry/opentelemetry-configuration/pull/526">opentelemetry-configuration#526</a>.
*/
@Deprecated
@Nullable
public static Map<String, String> peerServiceMapping(ConfigProvider configProvider) {
List<DeclarativeConfigProperties> serviceMappingList =
Expand Down
1 change: 1 addition & 0 deletions ...or/src/test/java/io/opentelemetry/api/incubator/config/InstrumentationConfigUtilTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ private static ConfigProvider toConfigProvider(String configYaml) {
new ByteArrayInputStream(configYaml.getBytes(StandardCharsets.UTF_8))));
}

@SuppressWarnings("deprecation") // testing deprecated method
@Test
void peerServiceMapping() {
assertThat(InstrumentationConfigUtil.peerServiceMapping(kitchenSinkConfigProvider))
Expand Down
Loading