Conversation
laurit
reviewed
Oct 22, 2025
| To use: | ||
|
|
||
| * Add a dependency on `io.opentelemetry.contrib:opentelemetry-cel-sampler:<version>` | ||
| * See the [extension documentation](https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/examples/extension/README.md#build-and-add-extensions) for how to add extensions when using the java agent. |
Contributor
There was a problem hiding this comment.
Since this module has an external dependency it can't just be added as an extension. User would first need to merge everything into single jar or also pass the cel jar as an extension (haven't tried that but since all the extensions are in the same class loader passing the dependencies as extensions should work). We could make this simpler by publishing shaded jars like in
Contributor
There was a problem hiding this comment.
@laurit Good point. I will have a look into this. Definitly an improvement.
trask
approved these changes
Dec 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A question came up in slack around whether this should be added as a dependency to the application classpath or if it's an agent extension, so I wanted to make this more clear