Skip to content

[CODE HEALTH] Use uint16_t for port numbers in ext/http/server - #4500

Merged
marcalff merged 4 commits into
open-telemetry:mainfrom
marcalff:fix_port
Aug 31, 2026
Merged

[CODE HEALTH] Use uint16_t for port numbers in ext/http/server#4500
marcalff merged 4 commits into
open-telemetry:mainfrom
marcalff:fix_port

Conversation

@marcalff

@marcalff marcalff commented Aug 29, 2026

Copy link
Copy Markdown
Member

Fixes #4305

Changes

Please provide a brief description of the changes here.

  • Code cleanup, use uint16_t for port numbers, in ext/http/server

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@marcalff
marcalff requested a review from a team as a code owner August 29, 2026 19:24
@codecov

codecov Bot commented Aug 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.25%. Comparing base (e68171d) to head (5aafe79).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4500      +/-   ##
==========================================
+ Coverage   83.24%   83.25%   +0.01%     
==========================================
  Files         521      521              
  Lines       20384    20384              
==========================================
+ Hits        16967    16969       +2     
+ Misses       3417     3415       -2     
Files with missing lines Coverage Δ
...nclude/opentelemetry/ext/http/server/http_server.h 66.67% <100.00%> (ø)
...clude/opentelemetry/ext/http/server/socket_tools.h 95.68% <100.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dbarker dbarker left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks

@marcalff
marcalff merged commit 58ed80d into open-telemetry:main Aug 31, 2026
76 of 77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] SocketAddr integer constructor silently wraps an out-of-range port

2 participants