[CMAKE] Remove environment variable support from the add external components script#4211
Open
dbarker wants to merge 3 commits into
Open
Conversation
…ake build using environment variables in favor or users building external components with opentelemetry-cpp as a dependency imported through find_package or FetchContent
…to remove env var support
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4211 +/- ##
==========================================
- Coverage 82.80% 82.79% -0.01%
==========================================
Files 415 415
Lines 17452 17452
==========================================
- Hits 14449 14447 -2
- Misses 3003 3005 +2 🚀 New features to boost your workflow:
|
owent
approved these changes
Jul 7, 2026
dbarker
commented
Jul 9, 2026
| # Prefer CMake option, then env variable, then URL. | ||
| # Add custom vendor component from local path | ||
| # CMake option. | ||
| if(OPENTELEMETRY_EXTERNAL_COMPONENT_PATH) |
Member
Author
There was a problem hiding this comment.
@ThomsonTan can you take a review pass?
OPENTELEMETRY_EXTERNAL_COMPONENT_PATH CMake variable is used by the opentelemetry-cpp vckpg port, but the environment variables for OPENTELEMETRY_EXTERNAL_COMPONENT_PATH and OPENTELEMETRY_EXTERNAL_COMPONENT_URL appear to be unused.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3409
Changes
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes