Skip to content

[CMAKE] Remove environment variable support from the add external components script#4211

Open
dbarker wants to merge 3 commits into
open-telemetry:mainfrom
dbarker:cmake_remove_external_components_from_env_feature
Open

[CMAKE] Remove environment variable support from the add external components script#4211
dbarker wants to merge 3 commits into
open-telemetry:mainfrom
dbarker:cmake_remove_external_components_from_env_feature

Conversation

@dbarker

@dbarker dbarker commented Jul 3, 2026

Copy link
Copy Markdown
Member

Fixes #3409

Changes

  • Removes OPENTELEMETRY_EXTERNAL_COMPONENT_PATH and OPENTELEMETRY_EXTERNAL_COMPONENT_URL environment variable support from the cmake/opentelemetry-build-external-component.cmake script

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

…ake build using environment variables in favor or users building external components with opentelemetry-cpp as a dependency imported through find_package or FetchContent
@dbarker dbarker marked this pull request as ready for review July 3, 2026 14:26
@dbarker dbarker requested a review from a team as a code owner July 3, 2026 14:26
@codecov

codecov Bot commented Jul 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.79%. Comparing base (c0dc559) to head (cecdc8b).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4211      +/-   ##
==========================================
- Coverage   82.80%   82.79%   -0.01%     
==========================================
  Files         415      415              
  Lines       17452    17452              
==========================================
- Hits        14449    14447       -2     
- Misses       3003     3005       +2     

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

# Prefer CMake option, then env variable, then URL.
# Add custom vendor component from local path
# CMake option.
if(OPENTELEMETRY_EXTERNAL_COMPONENT_PATH)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ThomsonTan can you take a review pass?

OPENTELEMETRY_EXTERNAL_COMPONENT_PATH CMake variable is used by the opentelemetry-cpp vckpg port, but the environment variables for OPENTELEMETRY_EXTERNAL_COMPONENT_PATH and OPENTELEMETRY_EXTERNAL_COMPONENT_URL appear to be unused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Harden the build external components feature

2 participants