[CODE HEALTH] clean up nostd::variant access in otlp exporters#3973
Draft
dbarker wants to merge 4 commits intoopen-telemetry:mainfrom
Draft
[CODE HEALTH] clean up nostd::variant access in otlp exporters#3973dbarker wants to merge 4 commits intoopen-telemetry:mainfrom
dbarker wants to merge 4 commits intoopen-telemetry:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3973 +/- ##
==========================================
+ Coverage 82.04% 82.08% +0.05%
==========================================
Files 385 385
Lines 15895 15916 +21
==========================================
+ Hits 13039 13063 +24
+ Misses 2856 2853 -3
🚀 New features to boost your workflow:
|
1948936 to
d03999c
Compare
d03999c to
294a38b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes # (issue)
Changes
nostd::holds_alternative/nostd::getif/else patternnostd::visitin otlp AnyValue attribute utilsnostd::get_ifin otlp http client and otlp metric utilsOtlpPopulateAttributeUtilsOtlpMetricUtilsto reduce data point copies and use constFor significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes