Skip to content

test: stabilize deferred model concurrency regression - #31060

Queued
IceS2 wants to merge 1 commit into
mainfrom
fix-deferred-model-concurrency-test
Queued

test: stabilize deferred model concurrency regression#31060
IceS2 wants to merge 1 commit into
mainfrom
fix-deferred-model-concurrency-test

Conversation

@IceS2

@IceS2 IceS2 commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Summary

  • isolate the deferred-model concurrency probe from coverage tracing
  • bound all
    synchronization and subprocess execution
  • assert every worker produces the correct result

Testing

  • full
    test module: 5 passed
  • pytest-cov execution: passed
  • unlocked mutation: failed with
    AttributeError(__pydantic_core_schema__) as expected

@IceS2
IceS2 requested a review from a team as a code owner August 5, 2026 16:38
Copilot AI review requested due to automatic review settings August 5, 2026 16:38

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

❌ PR checklist incomplete

This PR cannot be merged until the following are addressed on its linked issue:

  • No GitHub issue is linked. Link an issue in the Development section of the PR (or add Fixes #12345 to the description). For a same-org cross-repo issue, add Fixes open-metadata/<repo>#123 to the description.

The fields live on the linked issue in the Shipping project (open the issue → right sidebar → Projects). After you set them, re-run this check (or push a commit) — issue/project changes do not re-trigger it automatically.

Maintainers can bypass this check by adding the skip-pr-checks label.

@github-actions github-actions Bot added Ingestion safe to test Add this label to run secure Github workflows on PRs labels Aug 5, 2026
@gitar-bot

gitar-bot Bot commented Aug 5, 2026

Copy link
Copy Markdown
Code Review ✅ Approved

Isolates the deferred-model concurrency probe from coverage tracing and bounds synchronization to stabilize the test regression. No issues found.

Options

Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar | Powered by Gitar — free for open source

@sonarqubecloud

sonarqubecloud Bot commented Aug 5, 2026

Copy link
Copy Markdown

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

✅ Playwright Results — workflow succeeded

Validated commit 8b7660a28df0ffda6c5ccf09f1e52a2d21e070e6 in Playwright run 31026268297, attempt 1.

✅ 107 passed · ❌ 0 failed · 🟡 0 flaky · ⏭️ 0 skipped · 🧰 0 lifecycle flaky

Performance

Blocking targets: ✅ met · Optimization targets: 🟡 in progress

Shard-job maxima below are not the full workflow wall time; the linked run includes build, fixture, planning, and reporting.

🕒 Full workflow signal wall (to summary) 46m 45s

⏱️ Max setup 3m 9s · max shard execution 11m 29s · max shard-job elapsed before upload 17m 26s · reporting 4s

🌐 210.85 requests/attempt · 1.76 app boots/UI scenario · 0.00% common-shard skew

Optimization targets still in progress:

  • Browser traffic was 210.85 requests per attempt (convergence target: fewer than 200).
  • Application boot ratio was 1.76 per UI scenario (208 boots / 118 scenarios; convergence target: at most 1).
Shard Passed Failed Flaky Skipped Lifecycle failed Lifecycle flaky
✅ Shard chromium-01 46 0 0 0 0 0
✅ Shard ingestion-01 25 0 0 0 0 0
✅ Shard ingestion-02 36 0 0 0 0 0

📦 Download artifacts

How to debug locally
# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

@IceS2
IceS2 enabled auto-merge August 6, 2026 06:58
@IceS2
IceS2 added this pull request to the merge queue Aug 6, 2026
Any commits made after this event will not be merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ingestion safe to test Add this label to run secure Github workflows on PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants