Backport #29185 dashboard LCP parent optimizations to 1.13

[shah-harshit]

Summary

• Direct stacked backport for OSS sequence seq40: perf(ui): dashboard LCP optimization parent #29185.
• Uses the already reviewed 1.13 backport resolution from Backport dashboard LCP parent optimizations to 1.13 #30799.
• This PR is stacked on the previous sequence branch so it can be reviewed and merged in ticket order.

Tracking

• Source PR(s): perf(ui): dashboard LCP optimization parent #29185
• Source commit(s): 1c7ba76
• Common branch backport PR: Backport dashboard LCP parent optimizations to 1.13 #30799
• Cherry-picked commit: 4c0f822
• Depends on: ui/direct-1.13-seq39-29177-my-data-widget-deferral

Testing

• git diff --check HEAD~1..HEAD

[gitar-bot]

💡 Quality: Non-asserting isVisible() weakens follow-widget validation

In validateFollowedEntityToWidget, await followingWidget.isVisible() and await followingWidget.getByTestId(\following-${entity}`).isVisible()only return a boolean and are not assertions, so they never fail or auto-wait. The former poll-based logic guaranteed the entity card actually appeared; the new isFollowing branch will pass even if the followed entity is never rendered. Wrap the visibility checks inawait expect(...).toBeVisible()` so the assertion waits and fails correctly.

Fix:

if (isFollowing) {
  await expect(followingWidget).toBeVisible();
  await expect(
    followingWidget.getByTestId(`following-${entity}`)
  ).toBeVisible();
} else {
  await expect(followingWidget).toBeVisible();
  await expect(
    followingWidget.getByTestId(`following-${entity}`)
  ).not.toBeVisible();
}

• Apply fix

_{Check the box to apply the fix or reply for a change | Was this helpful? React with 👍 / 👎}

[gitar-bot]

Code Review 👍 Approved with suggestions 0 resolved / 1 findings

Backports dashboard LCP parent optimizations to 1.13, preserving prior resolution work. Consider adding assertions to isVisible() in validateFollowedEntityToWidget to strengthen follow-widget validation.

💡 Quality: Non-asserting isVisible() weakens follow-widget validation

📄 openmetadata-ui/src/main/resources/ui/playwright/utils/entity.ts:1450-1458

In validateFollowedEntityToWidget, await followingWidget.isVisible() and await followingWidget.getByTestId(\following-${entity}`).isVisible()only return a boolean and are not assertions, so they never fail or auto-wait. The former poll-based logic guaranteed the entity card actually appeared; the new isFollowing branch will pass even if the followed entity is never rendered. Wrap the visibility checks inawait expect(...).toBeVisible()` so the assertion waits and fails correctly.

Fix

if (isFollowing) {
  await expect(followingWidget).toBeVisible();
  await expect(
    followingWidget.getByTestId(`following-${entity}`)
  ).toBeVisible();
} else {
  await expect(followingWidget).toBeVisible();
  await expect(
    followingWidget.getByTestId(`following-${entity}`)
  ).not.toBeVisible();
}

🤖 Prompt for agents

Code Review: Backports dashboard LCP parent optimizations to 1.13, preserving prior resolution work. Consider adding assertions to isVisible() in validateFollowedEntityToWidget to strengthen follow-widget validation.

1. 💡 Quality: Non-asserting isVisible() weakens follow-widget validation
   Files: openmetadata-ui/src/main/resources/ui/playwright/utils/entity.ts:1450-1458

   In validateFollowedEntityToWidget, `await followingWidget.isVisible()` and `await followingWidget.getByTestId(\`following-${entity}\`).isVisible()` only return a boolean and are not assertions, so they never fail or auto-wait. The former poll-based logic guaranteed the entity card actually appeared; the new isFollowing branch will pass even if the followed entity is never rendered. Wrap the visibility checks in `await expect(...).toBeVisible()` so the assertion waits and fails correctly.

   Fix:
   if (isFollowing) {
     await expect(followingWidget).toBeVisible();
     await expect(
       followingWidget.getByTestId(`following-${entity}`)
     ).toBeVisible();
   } else {
     await expect(followingWidget).toBeVisible();
     await expect(
       followingWidget.getByTestId(`following-${entity}`)
     ).not.toBeVisible();
   }

Options

Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Compact

gitar display:verbose

_{Was this helpful? React with 👍 / 👎 | Gitar | Powered by Gitar — free for open source}

[github-actions]

❌ UI Checkstyle Failed

❌ ESLint + Prettier + Organise Imports (src)

One or more source files have linting or formatting issues.

❌ Licence Header

One or more files are missing or have an outdated Apache 2.0 licence header.

Affected files

• openmetadata-ui/src/main/resources/ui/src/components/ActivityFeed/TaskFeedCard/TaskFeedCardFromTask.component.test.tsx
  • openmetadata-ui/src/main/resources/ui/src/components/NotificationBox/NotificationFeedCard.test.tsx
  • openmetadata-ui/src/main/resources/ui/src/pages/TasksPage/shared/TaskPayloadSchemaFields.tsx
  • openmetadata-ui/src/main/resources/ui/src/utils/TaskFormSchemaUtils.ts

❌ Tailwind Audit

Hardcoded Tailwind values found. Use a design-system utility (run yarn tw-audit:report for the token each value maps to).

❌ Antd + Less Deprecation Guard

A new antd import or new .less file was added. Use UntitledUI + Tailwind for new work.

Affected files

at Function._resolveFilename (node:internal/modules/cjs/loader:1401:15)
at defaultResolveImpl (node:internal/modules/cjs/loader:1057:19)
at resolveForCJSWithHooks (node:internal/modules/cjs/loader:1062:22)
at Function._load (node:internal/modules/cjs/loader:1211:37)
at TracingChannel.traceSync (node:diagnostics_channel:322:14)
at wrapModuleLoad (node:internal/modules/cjs/loader:235:24)
at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:171:5)
at node:internal/main/run_main_module:36:49 {

---

Fix locally (fast - only checks files changed in this branch):

make ui-checkstyle-changed