Backport #29065 Domain and Glossary lazy-loading to 1.13

[shah-harshit]

Summary

• Direct stacked backport for OSS sequence seq25: feat(ui): update Domain & Glossary components for lazy-load utility pattern #29065.
• Uses the already reviewed 1.13 backport resolution from Backport Domain and Glossary lazy-loading updates to 1.13 #30129.
• This PR is stacked on the previous sequence branch so it can be reviewed and merged in ticket order.
• Conflict resolution keeps current 1.13 domain/glossary intake-form extension behavior while applying the lazy-loading utility split.

Tracking

• Source PR(s): feat(ui): update Domain & Glossary components for lazy-load utility pattern #29065
• Source commit(s): 95327a5
• Common branch backport PR: Backport Domain and Glossary lazy-loading updates to 1.13 #30129
• Cherry-picked commit: 5b92d40
• Depends on: ui/direct-1.13-seq24-29062-activityfeed-announcement-lazy

Testing

• git diff --check HEAD~1..HEAD

[greptile-apps]

Too many files changed for review (167 files, 100 file limit).

Bypass the limit by tagging @greptile-apps to review.

[github-actions]

❌ PR checklist incomplete

This PR cannot be merged until the following are addressed on its linked issue:

• No GitHub issue is linked. Link an issue in the Development section of the PR (or add Fixes #12345 to the description). For a same-org cross-repo issue, add Fixes open-metadata/<repo>#123 to the description.

The fields live on the linked issue in the Shipping project (open the issue → right sidebar → Projects). After you set them, re-run this check (or push a commit) — issue/project changes do not re-trigger it automatically.

Maintainers can bypass this check by adding the skip-pr-checks label.

[gitar-bot]

💡 Quality: New exported transformDomainFormData helpers are unused dead code

DOMAIN_FORM_DEFAULTS, transformDomainFormData, normalizeExtensionForApi, unwrapSelectItemValue, and isFormSelectItem (~130 new lines) are exported but have no callers anywhere in the codebase, including tests — the component's own handleFormSubmit builds the payload inline instead. This duplicated, untested transform can silently drift from the real submit path (e.g. it drops reviewers for non-data-product domains, unlike the inline handler). If they aren't consumed by a later stacked PR, remove them; otherwise route handleFormSubmit through transformDomainFormData so a single code path is exercised and tested.

_{Was this helpful? React with 👍 / 👎}

[gitar-bot]

Code Review 👍 Approved with suggestions 0 resolved / 1 findings

Backports Domain and Glossary lazy-loading updates to the 1.13 branch. Consider removing the unused exported transformDomainFormData helpers to clean up dead code.

💡 Quality: New exported transformDomainFormData helpers are unused dead code

📄 openmetadata-ui/src/main/resources/ui/src/components/Domain/AddDomainForm/AddDomainForm.component.tsx:78-92

DOMAIN_FORM_DEFAULTS, transformDomainFormData, normalizeExtensionForApi, unwrapSelectItemValue, and isFormSelectItem (~130 new lines) are exported but have no callers anywhere in the codebase, including tests — the component's own handleFormSubmit builds the payload inline instead. This duplicated, untested transform can silently drift from the real submit path (e.g. it drops reviewers for non-data-product domains, unlike the inline handler). If they aren't consumed by a later stacked PR, remove them; otherwise route handleFormSubmit through transformDomainFormData so a single code path is exercised and tested.

🤖 Prompt for agents

Code Review: Backports Domain and Glossary lazy-loading updates to the 1.13 branch. Consider removing the unused exported transformDomainFormData helpers to clean up dead code.

1. 💡 Quality: New exported transformDomainFormData helpers are unused dead code
   Files: openmetadata-ui/src/main/resources/ui/src/components/Domain/AddDomainForm/AddDomainForm.component.tsx:78-92

   `DOMAIN_FORM_DEFAULTS`, `transformDomainFormData`, `normalizeExtensionForApi`, `unwrapSelectItemValue`, and `isFormSelectItem` (~130 new lines) are exported but have no callers anywhere in the codebase, including tests — the component's own `handleFormSubmit` builds the payload inline instead. This duplicated, untested transform can silently drift from the real submit path (e.g. it drops `reviewers` for non-data-product domains, unlike the inline handler). If they aren't consumed by a later stacked PR, remove them; otherwise route `handleFormSubmit` through `transformDomainFormData` so a single code path is exercised and tested.

Options

Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Compact

gitar display:verbose

_{Was this helpful? React with 👍 / 👎 | Gitar | Powered by Gitar — free for open source}