Skip to content

Backport #29062 ActivityFeed and Announcement lazy-loading to 1.13 - #31042

Open
shah-harshit wants to merge 3 commits into
1.13from
ui/direct-1.13-seq24-29062-activityfeed-announcement-lazy
Open

Backport #29062 ActivityFeed and Announcement lazy-loading to 1.13#31042
shah-harshit wants to merge 3 commits into
1.13from
ui/direct-1.13-seq24-29062-activityfeed-announcement-lazy

Conversation

@shah-harshit

Copy link
Copy Markdown
Contributor

Summary

Tracking

Testing

  • git diff --check HEAD~1..HEAD

@shah-harshit
shah-harshit requested a review from a team as a code owner August 5, 2026 13:26
@shah-harshit shah-harshit added UI UI specific issues safe to test Add this label to run secure Github workflows on PRs skip-pr-checks Bypass PR metadata validation check labels Aug 5, 2026
@shah-harshit shah-harshit self-assigned this Aug 5, 2026
@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

❌ UI Checkstyle Failed

❌ ESLint + Prettier + Organise Imports (src)

One or more source files have linting or formatting issues.

❌ Tailwind Audit

Hardcoded Tailwind values found. Use a design-system utility (run yarn tw-audit:report for the token each value maps to).

❌ Antd + Less Deprecation Guard

A new antd import or new .less file was added. Use UntitledUI + Tailwind for new work.

Affected files

at Function._resolveFilename (node:internal/modules/cjs/loader:1401:15)
at defaultResolveImpl (node:internal/modules/cjs/loader:1057:19)
at resolveForCJSWithHooks (node:internal/modules/cjs/loader:1062:22)
at Function._load (node:internal/modules/cjs/loader:1211:37)
at TracingChannel.traceSync (node:diagnostics_channel:322:14)
at wrapModuleLoad (node:internal/modules/cjs/loader:235:24)
at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:171:5)
at node:internal/main/run_main_module:36:49 {


Fix locally (fast - only checks files changed in this branch):

make ui-checkstyle-changed

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 63%
63.86% (61970/97036) 44.67% (33488/74956) 46.98% (10347/22024)

@sonarqubecloud

sonarqubecloud Bot commented Aug 5, 2026

Copy link
Copy Markdown

Base automatically changed from ui/direct-1.13-seq23-29064-dataquality-incident-lazy-loading to 1.13 August 6, 2026 04:11
… utility pattern (#29062) (#30128)

* feat(ui): update ActivityFeed & Announcement components for lazy-load utility pattern

Updates ActivityFeed components to import from extracted pure utility modules. Updates FeedUtils, TasksUtils imports to use new utility structure. Updates TasksPage and tasksAPI for consistent utility usage.

Ref: open-metadata/openmetadata-collate#4230

* fix imports

* address gitar-bot comments

* fix checkstyle

* fix failing tests

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
(cherry picked from commit 874dbed)
@shah-harshit
shah-harshit force-pushed the ui/direct-1.13-seq24-29062-activityfeed-announcement-lazy branch from 8c69fa7 to 327b810 Compare August 6, 2026 04:15
@gitar-bot

gitar-bot Bot commented Aug 6, 2026

Copy link
Copy Markdown
Code Review ✅ Approved

Backports ActivityFeed and Announcement component lazy-loading to 1.13 and removes a duplicate CodeEditor declaration. No issues found.

Options

Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar | Powered by Gitar — free for open source

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs skip-pr-checks Bypass PR metadata validation check UI UI specific issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant