Skip to content

[ESLint 8/10] Fix playwright/* warnings - #30998

Merged
ShaileshParmar11 merged 0 commit into
ShaileshParmar11/eslint-09-exhaustive-depsfrom
ShaileshParmar11/eslint-10-playwright
Aug 5, 2026
Merged

[ESLint 8/10] Fix playwright/* warnings#30998
ShaileshParmar11 merged 0 commit into
ShaileshParmar11/eslint-09-exhaustive-depsfrom
ShaileshParmar11/eslint-10-playwright

Conversation

@ShaileshParmar11

@ShaileshParmar11 ShaileshParmar11 commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Fixes #30987. Part of epic #30977.

Stacked PR 8 of 10 — base branch ShaileshParmar11/eslint-08-i18n. Top of the stack. The diff here contains only the playwright/* changes.

⚠️ Stacked, not independent — this PR merges after #the one below it in the stack; GitHub auto-retargets the base to main as each lands. See epic #30977 for the full approach and reviewer caveats.

Behavior-preserving lint cleanup. Verified: target rule(s) → 0, no new warnings (git-stash ESLint before/after), 0 new tsc signatures vs baseline.

🤖 Generated with Claude Code


Reviewer notes — why suppressed (playwright)

These are E2E tests that cannot be run/verified from this change, so rewriting them risks destabilising the suite. no-restricted-syntax (browser.newPage() multi-context pattern), no-wait-for-timeout/no-wait-for-selector, no-force-option, and no-skipped-test are resolved with eslint-disable-next-line … -- <reason> (no test logic changed). The only genuine fixes are the @typescript-eslint/no-explicit-any hits, which got real types. Rewriting the waits/auth to satisfy the rules is worthwhile but belongs in a dedicated, separately-canaried test-quality pass.

@ShaileshParmar11
ShaileshParmar11 requested a review from a team as a code owner August 5, 2026 06:27
@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

❌ PR checklist incomplete

This PR cannot be merged until the following are addressed on its linked issue:

  • No GitHub issue is linked. Link an issue in the Development section of the PR (or add Fixes #12345 to the description). For a same-org cross-repo issue, add Fixes open-metadata/<repo>#123 to the description.

The fields live on the linked issue in the Shipping project (open the issue → right sidebar → Projects). After you set them, re-run this check (or push a commit) — issue/project changes do not re-trigger it automatically.

Maintainers can bypass this check by adding the skip-pr-checks label.

@github-actions github-actions Bot added safe to test Add this label to run secure Github workflows on PRs UI UI specific issues labels Aug 5, 2026
@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

🔴 Playwright Results — workflow failed

Validated commit c404db217a529c1430e4e73478033977dedbc36c in Playwright run 30992080679, attempt 1.

✅ 1687 passed · ❌ 0 failed · 🟡 4 flaky · ⏭️ 1 skipped · 🧰 0 lifecycle flaky

Pipeline and setup failures (4)

  • Playwright performance gate Maximum shard-job elapsed before upload failed (target ≤ 1800 s) — exceeded on 1 shard(s): chromium-10 1988 s.
  • Playwright coverage validation found 170 missing, 0 unexpected, 0 duplicate-plan, and 0 duplicate-execution test ID(s).
  • Shard chromium-02 did not upload a usable Playwright results artifact.
  • Shard chromium-02 did not upload its execution status.

Performance

Blocking targets: ❌ unmet · Optimization targets: 🟡 in progress

Shard-job maxima below are not the full workflow wall time; the linked run includes build, fixture, planning, and reporting.

🕒 Full workflow signal wall (to summary) 1h 4m 26s

⏱️ Max setup 3m 10s · max shard execution 20m 34s · max shard-job elapsed before upload 33m 8s · reporting 7s

🌐 222.96 requests/attempt · 2.92 app boots/UI scenario · 6.89% common-shard skew

Optimization targets still in progress:

  • Browser traffic was 222.96 requests per attempt (convergence target: fewer than 200).
  • Application boot ratio was 2.92 per UI scenario (5441 boots / 1864 scenarios; convergence target: at most 1).
Shard Passed Failed Flaky Skipped Lifecycle failed Lifecycle flaky
✅ Shard chromium-01 178 0 0 0 0 0
⛔ Shard chromium-02
✅ Shard chromium-03 161 0 0 0 0 0
🟡 Shard chromium-04 165 0 1 0 0 0
✅ Shard chromium-05 163 0 0 0 0 0
🟡 Shard chromium-06 154 0 2 0 0 0
🟡 Shard chromium-07 158 0 1 0 0 0
✅ Shard chromium-08 155 0 0 0 0 0
✅ Shard chromium-09 155 0 0 0 0 0
✅ Shard chromium-10 166 0 0 1 0 0
✅ Shard data-asset-rules-01 61 0 0 0 0 0
✅ Shard domain-isolation-01 14 0 0 0 0 0
✅ Shard global-state-01 34 0 0 0 0 0
✅ Shard import-export-01 65 0 0 0 0 0
✅ Shard ingestion-01 17 0 0 0 0 0
✅ Shard reindex-01 2 0 0 0 0 0
✅ Shard search-01 10 0 0 0 0 0
✅ Shard search-rbac-01 29 0 0 0 0 0
🟡 4 flaky test(s) (passed on retry)
  • Features/NavigationBlocker.spec.tsshould not show navigation blocker after saving changes (shard chromium-04, 1 retry)
  • Pages/Entity.spec.tsDomain Propagation (shard chromium-06, 1 retry)
  • Pages/TasksUIFlow.spec.tsCreate and resolve description task for Pipeline via UI (shard chromium-06, 1 retry)
  • Pages/DataContracts.spec.tsCreate Data Contract and validate for ApiEndpoint (shard chromium-07, 1 retry)

📦 Download artifacts

How to debug locally
# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

@ShaileshParmar11
ShaileshParmar11 force-pushed the ShaileshParmar11/eslint-09-exhaustive-deps branch from ba75305 to 5d2b3c3 Compare August 5, 2026 07:33
@ShaileshParmar11
ShaileshParmar11 force-pushed the ShaileshParmar11/eslint-10-playwright branch from b762e99 to deeb7ed Compare August 5, 2026 07:33
@ShaileshParmar11
ShaileshParmar11 force-pushed the ShaileshParmar11/eslint-09-exhaustive-deps branch from 5d2b3c3 to 7561d54 Compare August 5, 2026 07:53
@ShaileshParmar11
ShaileshParmar11 force-pushed the ShaileshParmar11/eslint-09-exhaustive-deps branch from 71b9a4f to 048a3c5 Compare August 5, 2026 09:09
@ShaileshParmar11
ShaileshParmar11 force-pushed the ShaileshParmar11/eslint-10-playwright branch from 301efb4 to c404db2 Compare August 5, 2026 09:09
@ShaileshParmar11
ShaileshParmar11 force-pushed the ShaileshParmar11/eslint-10-playwright branch from c404db2 to b1bb230 Compare August 5, 2026 12:13
@ShaileshParmar11
ShaileshParmar11 merged commit b1bb230 into ShaileshParmar11/eslint-09-exhaustive-deps Aug 5, 2026
14 of 16 checks passed
@greptile-apps

greptile-apps Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Too many files changed for review (600 files, 100 file limit).

@gitar-bot

gitar-bot Bot commented Aug 5, 2026

Copy link
Copy Markdown
Code Review ✅ Approved

Behavior-preserving lint cleanup resolving Playwright ESLint warnings across UI test files. No issues found.

Options

Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar | Powered by Gitar — free for open source

@ShaileshParmar11

Copy link
Copy Markdown
Contributor Author

Superseded by #31032. Auto-closed during a stack reorder (head became an ancestor of its old base; nothing merged into main). The Playwright changes now live in #31032. Please review there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs UI UI specific issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant