[ESLint 7/10] Fix i18next/no-literal-string warnings - #30996
Conversation
❌ PR checklist incompleteThis PR cannot be merged until the following are addressed on its linked issue:
The fields live on the linked issue in the Shipping project (open the issue → right sidebar → Projects). After you set them, re-run this check (or push a commit) — issue/project changes do not re-trigger it automatically. Maintainers can bypass this check by adding the |
🔴 Playwright Results — workflow failedValidated commit ✅ 0 passed · ❌ 0 failed · 🟡 0 flaky · ⏭️ 0 skipped · 🧰 0 lifecycle flaky Pipeline and setup failures (24)
Performance⚪ Performance metrics unavailable; see the CI and reporting failures above.
How to debug locally# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip # view trace |
f2b88c8 to
67e202c
Compare
fa17259 to
7d7f84f
Compare
67e202c to
e007df4
Compare
7d7f84f to
1d2f443
Compare
e007df4 to
1b00444
Compare
1d2f443 to
82004b0
Compare
1b00444 to
c926324
Compare
82004b0 to
3ff7e26
Compare
3ff7e26 to
660e26d
Compare
660e26d
into
ShaileshParmar11/eslint-07-complexity
c926324 to
69e6308
Compare
|
Too many files changed for review (700 files, 100 file limit). |
Code Review ✅ ApprovedWraps hardcoded UI strings in i18next translation calls to resolve ESLint i18next/no-literal-string warnings. No issues found. OptionsDisplay: compact → Showing less information. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Gitar | Powered by Gitar — free for open source |
Fixes #30985. Part of epic #30977.
Stacked PR 7 of 10 — base branch
ShaileshParmar11/eslint-06-duplicate-string. Review after the previous PR in the stack. The diff here contains only the i18next/no-literal-string changes.mainas each lands. See epic #30977 for the full approach and reviewer caveats.Behavior-preserving lint cleanup. Verified: target rule(s) → 0, no new warnings (git-stash ESLint before/after), 0 new tsc signatures vs baseline.
🤖 Generated with Claude Code
Reviewer notes — the i18n approach
98% (2,242) of the⚠️ The 26 keys land as English placeholders in the 19 non-English locales — real translation is unavoidable human follow-up (CI only verifies key sync, which passes).
i18next/no-literal-stringwarnings were in test/spec/mock files, which contain no user-facing strings. Rather than 2,242 inline disables, the rule is turned off for test/spec/mock files via the existing test-file override ineslint.config.mjs— one config line (trivially reversible). The 40 genuine production strings are properly internationalised witht()+ 26 new alphabetically-sorteden-us.jsonkeys;yarn i18nthen synced all 20 locale files.