Skip to content

[ESLint 7/10] Fix i18next/no-literal-string warnings - #30996

Merged
ShaileshParmar11 merged 0 commit into
ShaileshParmar11/eslint-07-complexityfrom
ShaileshParmar11/eslint-08-i18n
Aug 5, 2026
Merged

[ESLint 7/10] Fix i18next/no-literal-string warnings#30996
ShaileshParmar11 merged 0 commit into
ShaileshParmar11/eslint-07-complexityfrom
ShaileshParmar11/eslint-08-i18n

Conversation

@ShaileshParmar11

@ShaileshParmar11 ShaileshParmar11 commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Fixes #30985. Part of epic #30977.

Stacked PR 7 of 10 — base branch ShaileshParmar11/eslint-06-duplicate-string. Review after the previous PR in the stack. The diff here contains only the i18next/no-literal-string changes.

⚠️ Stacked, not independent — this PR merges after #the one below it in the stack; GitHub auto-retargets the base to main as each lands. See epic #30977 for the full approach and reviewer caveats.

Behavior-preserving lint cleanup. Verified: target rule(s) → 0, no new warnings (git-stash ESLint before/after), 0 new tsc signatures vs baseline.

🤖 Generated with Claude Code


Reviewer notes — the i18n approach

98% (2,242) of the i18next/no-literal-string warnings were in test/spec/mock files, which contain no user-facing strings. Rather than 2,242 inline disables, the rule is turned off for test/spec/mock files via the existing test-file override in eslint.config.mjs — one config line (trivially reversible). The 40 genuine production strings are properly internationalised with t() + 26 new alphabetically-sorted en-us.json keys; yarn i18n then synced all 20 locale files. ⚠️ The 26 keys land as English placeholders in the 19 non-English locales — real translation is unavoidable human follow-up (CI only verifies key sync, which passes).

@ShaileshParmar11
ShaileshParmar11 requested a review from a team as a code owner August 5, 2026 06:24
@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

❌ PR checklist incomplete

This PR cannot be merged until the following are addressed on its linked issue:

  • No GitHub issue is linked. Link an issue in the Development section of the PR (or add Fixes #12345 to the description). For a same-org cross-repo issue, add Fixes open-metadata/<repo>#123 to the description.

The fields live on the linked issue in the Shipping project (open the issue → right sidebar → Projects). After you set them, re-run this check (or push a commit) — issue/project changes do not re-trigger it automatically.

Maintainers can bypass this check by adding the skip-pr-checks label.

@github-actions github-actions Bot added safe to test Add this label to run secure Github workflows on PRs UI UI specific issues labels Aug 5, 2026
@ShaileshParmar11 ShaileshParmar11 changed the title [ESLint 9/10] Fix i18next/no-literal-string warnings [ESLint 8/10] Fix i18next/no-literal-string warnings Aug 5, 2026
@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

🔴 Playwright Results — workflow failed

Validated commit 3ff7e26e8f5da1089e610a1805da4c451ecef4cf in Playwright run 30992072560, attempt 1.

✅ 0 passed · ❌ 0 failed · 🟡 0 flaky · ⏭️ 0 skipped · 🧰 0 lifecycle flaky

Pipeline and setup failures (24)

  • Seeded fixture preparation finished with status failure.
  • The Playwright shard matrix was unexpectedly skipped.
  • Shard chromium-01 did not upload a usable Playwright results artifact.
  • Shard chromium-02 did not upload a usable Playwright results artifact.
  • Shard chromium-03 did not upload a usable Playwright results artifact.
  • Shard data-asset-rules-01 did not upload a usable Playwright results artifact.
  • Shard domain-isolation-01 did not upload a usable Playwright results artifact.
  • Shard global-state-01 did not upload a usable Playwright results artifact.
  • Shard ingestion-01 did not upload a usable Playwright results artifact.
  • Shard ingestion-02 did not upload a usable Playwright results artifact.
  • Shard reindex-01 did not upload a usable Playwright results artifact.
  • Shard search-01 did not upload a usable Playwright results artifact.
  • Shard search-rbac-01 did not upload a usable Playwright results artifact.
  • Shard chromium-01 did not upload its execution status.
  • Shard chromium-02 did not upload its execution status.
  • Shard chromium-03 did not upload its execution status.
  • Shard data-asset-rules-01 did not upload its execution status.
  • Shard domain-isolation-01 did not upload its execution status.
  • Shard global-state-01 did not upload its execution status.
  • Shard ingestion-01 did not upload its execution status.
  • Shard ingestion-02 did not upload its execution status.
  • Shard reindex-01 did not upload its execution status.
  • Shard search-01 did not upload its execution status.
  • Shard search-rbac-01 did not upload its execution status.

Performance

⚪ Performance metrics unavailable; see the CI and reporting failures above.

Shard Passed Failed Flaky Skipped Lifecycle failed Lifecycle flaky
⛔ Shard chromium-01
⛔ Shard chromium-02
⛔ Shard chromium-03
⛔ Shard data-asset-rules-01
⛔ Shard domain-isolation-01
⛔ Shard global-state-01
⛔ Shard ingestion-01
⛔ Shard ingestion-02
⛔ Shard reindex-01
⛔ Shard search-01
⛔ Shard search-rbac-01

📦 Download artifacts

How to debug locally
# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

@ShaileshParmar11
ShaileshParmar11 force-pushed the ShaileshParmar11/eslint-07-complexity branch from 1b00444 to c926324 Compare August 5, 2026 09:09
@ShaileshParmar11
ShaileshParmar11 force-pushed the ShaileshParmar11/eslint-08-i18n branch from 82004b0 to 3ff7e26 Compare August 5, 2026 09:09
@ShaileshParmar11
ShaileshParmar11 force-pushed the ShaileshParmar11/eslint-08-i18n branch from 3ff7e26 to 660e26d Compare August 5, 2026 12:13
@ShaileshParmar11
ShaileshParmar11 merged commit 660e26d into ShaileshParmar11/eslint-07-complexity Aug 5, 2026
6 of 7 checks passed
@ShaileshParmar11
ShaileshParmar11 force-pushed the ShaileshParmar11/eslint-07-complexity branch from c926324 to 69e6308 Compare August 5, 2026 12:13
@greptile-apps

greptile-apps Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Too many files changed for review (700 files, 100 file limit).

@ShaileshParmar11
ShaileshParmar11 deleted the ShaileshParmar11/eslint-08-i18n branch August 5, 2026 12:13
@ShaileshParmar11 ShaileshParmar11 changed the title [ESLint 8/10] Fix i18next/no-literal-string warnings [ESLint 7/10] Fix i18next/no-literal-string warnings Aug 5, 2026
@gitar-bot

gitar-bot Bot commented Aug 5, 2026

Copy link
Copy Markdown
Code Review ✅ Approved

Wraps hardcoded UI strings in i18next translation calls to resolve ESLint i18next/no-literal-string warnings. No issues found.

Options

Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar | Powered by Gitar — free for open source

@ShaileshParmar11
ShaileshParmar11 restored the ShaileshParmar11/eslint-08-i18n branch August 5, 2026 12:15
@ShaileshParmar11

Copy link
Copy Markdown
Contributor Author

Superseded by #31031. This PR was auto-closed by GitHub during a stack reorder (its head branch became an ancestor of its old base, so GitHub marked it "merged" — nothing actually merged into main). The i18n changes now live in #31031 with the correct base. Please review there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs UI UI specific issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant