Skip to content

Addressed design comment for context center dashboard page#29164

Merged
Rohit0301 merged 5 commits into
mainfrom
fix-29158
Jun 18, 2026
Merged

Addressed design comment for context center dashboard page#29164
Rohit0301 merged 5 commits into
mainfrom
fix-29158

Conversation

@Rohit0301

@Rohit0301 Rohit0301 commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Describe your changes:

Screenshot 2026-06-18 at 3 45 44 PM

Fixes 29158

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

High-level design:

N/A — small change.

Tests:

Use cases covered

Unit tests

Backend integration tests

Ingestion integration tests

Playwright (UI) tests

Manual testing performed

UI screen recording / screenshots:

Not applicable.

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • My PR is linked to a GitHub issue via Fixes #<issue-number> above.
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.
  • For UI changes: I attached a screen recording and/or screenshots above.
  • I have added tests (unit / integration / Playwright as applicable) and listed them above.

Greptile Summary

This PR addresses design feedback for the Context Center dashboard page, cleaning up visual styling and fixing a previously flagged double-navigation bug.

  • Removes divider borders between RecentItem rows and the top-section separator borders in ContextKnowledgePillarCard, strips tw:font-mono from meta text, and downgrades three section header labels from weight="semibold" to weight="medium".
  • Swaps getRelativeTime for getShortRelativeTime in ContextCenterDashboardPage so timestamps in the article/document meta line are abbreviated (e.g. "10 mins ago").
  • Fixes the double-navigation issue on the CTA button by adding e.stopPropagation() and disables the button via isDisabled={hasNoData} when the recent list is empty.

Confidence Score: 5/5

Safe to merge — all changes are localised to visual styling and a targeted interaction fix with no backend or data-flow impact.

The changes are purely cosmetic (border/divider removal, font-weight adjustments, abbreviated timestamps) plus a correctly implemented fix for the previously reported double-navigation on the CTA button. No logic paths, data fetching, or shared utilities are altered in a way that could regress existing behaviour.

No files require special attention.

Important Files Changed

Filename Overview
openmetadata-ui/src/main/resources/ui/src/components/ContextCenter/ContextKnowledgePillarCard/ContextKnowledgePillarCard.component.tsx Removes item dividers and top-section border, drops tw:font-mono from meta text, changes title weight to "medium", adds hasNoData guard to disable the CTA button when recent is empty, and fixes the double-navigation bug with e.stopPropagation() on the Button's click handler.
openmetadata-ui/src/main/resources/ui/src/pages/ContextCenterPage/ContextCenterDashboardPage/ContextCenterDashboardPage.tsx Swaps getRelativeTime for getShortRelativeTime on article and document timestamps so the meta line shows abbreviated units (e.g. "10 mins ago" instead of "10 minutes ago").
openmetadata-ui/src/main/resources/ui/src/components/ContextCenter/AiActivitySection/AiActivitySection.component.tsx Single-line typography weight change from "semibold" to "medium" for the "Used by AI" section header label.
openmetadata-ui/src/main/resources/ui/src/components/ContextCenter/NeedsAttentionSection/NeedsAttentionSection.component.tsx Single-line typography weight change from "semibold" to "medium" for the "Needs Attention" section header label.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Card onClick] -->|user clicks card body| B[navigate to route]
    A -->|user clicks CTA Button| C{hasNoData?}
    C -->|true| D[Button isDisabled — no action]
    C -->|false| E[e.stopPropagation stops bubble to Card]
    E --> F[onClick callback fires once]
    F --> B
Loading
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
    A[Card onClick] -->|user clicks card body| B[navigate to route]
    A -->|user clicks CTA Button| C{hasNoData?}
    C -->|true| D[Button isDisabled — no action]
    C -->|false| E[e.stopPropagation stops bubble to Card]
    E --> F[onClick callback fires once]
    F --> B
Loading

Reviews (5): Last reviewed commit: "lint fix" | Re-trigger Greptile

@Rohit0301 Rohit0301 self-assigned this Jun 18, 2026
@Rohit0301 Rohit0301 requested a review from a team as a code owner June 18, 2026 06:57
@Rohit0301 Rohit0301 added safe to test Add this label to run secure Github workflows on PRs skip-pr-checks Bypass PR metadata validation check labels Jun 18, 2026
@github-actions

github-actions Bot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 62%
62.27% (66607/106950) 44.04% (37261/84603) 45.38% (11189/24654)

@github-actions

github-actions Bot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

🟡 Playwright Results — all passed (11 flaky)

✅ 4303 passed · ❌ 0 failed · 🟡 11 flaky · ⏭️ 88 skipped

Shard Passed Failed Flaky Skipped
✅ Shard 1 302 0 0 4
🟡 Shard 2 808 0 4 9
🟡 Shard 3 813 0 3 8
🟡 Shard 4 856 0 1 12
🟡 Shard 5 732 0 1 47
🟡 Shard 6 792 0 2 8
🟡 11 flaky test(s) (passed on retry)
  • Features/DataProductRenameConsolidation.spec.ts › Rename then update description - assets should be preserved (shard 2, 1 retry)
  • Features/DataQuality/ColumnLevelTests.spec.ts › Column Values To Be Not In Set (shard 2, 1 retry)
  • Features/DataQuality/IncidentManagerDateFilter.spec.ts › should close sort dropdown after selecting an option (shard 2, 1 retry)
  • Features/Glossary/GlossaryP3Tests.spec.ts › should handle multiple rapid API calls (shard 2, 1 retry)
  • Features/KnowledgeCenterList.spec.ts › Knowledge Center List - Verify Recently Viewed widget (shard 3, 1 retry)
  • Features/McpChat.spec.ts › Clicking MCP Chat sidebar nav should navigate to chat page (shard 3, 1 retry)
  • Features/RestoreEntityInheritedFields.spec.ts › Validate restore with Inherited domain and data products assigned (shard 3, 1 retry)
  • Pages/CustomProperties.spec.ts › Set & Update all CP types on database (shard 4, 1 retry)
  • Pages/ExplorePageRightPanel_KnowledgeCenter.spec.ts › Should remove user owner for knowledgeCenter (shard 5, 1 retry)
  • Pages/Lineage/DataAssetLineage.spec.ts › Column lineage for searchIndex -> dashboardDataModel (shard 6, 1 retry)
  • Pages/Lineage/LineageFilters.spec.ts › Verify lineage schema filter selection (shard 6, 1 retry)

📦 Download artifacts

How to debug locally
# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

@sonarqubecloud

Copy link
Copy Markdown

@Rohit0301 Rohit0301 merged commit 9ddc80c into main Jun 18, 2026
51 checks passed
@Rohit0301 Rohit0301 deleted the fix-29158 branch June 18, 2026 13:12
@gitar-bot

gitar-bot Bot commented Jun 18, 2026

Copy link
Copy Markdown
Code Review ✅ Approved 1 resolved / 1 findings

Refines the Context Center dashboard UI with updated typography, divider removals, and compact timestamp formatting, while resolving the CTA button double-navigation issue.

✅ 1 resolved
Bug: CTA button onClick duplicates the Card's onClick via bubbling

📄 openmetadata-ui/src/main/resources/ui/src/components/ContextCenter/ContextKnowledgePillarCard/ContextKnowledgePillarCard.component.tsx:137 📄 openmetadata-ui/src/main/resources/ui/src/components/ContextCenter/ContextKnowledgePillarCard/ContextKnowledgePillarCard.component.tsx:198-207
The root Card already has onClick={onClick} (line 137). The newly added onClick={onClick} on the inner Button (line 205) will bubble up to the Card, so a click on the CTA invokes onClick twice. If onClick performs navigation that is usually harmless, but for handlers that toggle state, push history, or fire analytics it will double-fire.

Additionally, the Button is disabled when hasNoData, but the Card still carries onClick and tw:cursor-pointer unconditionally, so the card body remains clickable even with no data — inconsistent with the disabled CTA.

Consider either removing the Button's onClick (let the Card handle it) or stopping propagation, and gating the Card's onClick/cursor on hasNoData.

Options

Display: compact → Showing less information.

Comment with these commands to change:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs skip-pr-checks Bypass PR metadata validation check

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fixed font issues on context center dashboard page

2 participants