You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
📄 openmetadata-ui/src/main/resources/ui/playwright/utils/lineage.ts:514-516
Using dispatchEvent('click') instead of .click() bypasses Playwright's built-in actionability checks (e.g., ensuring the element is not obscured by overlays, is enabled, etc.). While this works around a flaky test, it may mask real UI issues where the button is covered or not truly interactive. The explicit waitFor({ state: 'visible' }) only partially compensates — visibility doesn't guarantee the element is unobscured or clickable.
Consider using .click({ force: true }) instead, which still uses Playwright's click mechanism but skips the actionability checks. Alternatively, investigate why the standard .click() was failing (e.g., an overlay or animation) and fix the root cause.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
safe to testAdd this label to run secure Github workflows on PRs
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes:
Column level lineage test - test is getting timed out
data asset lineage spec - click in canvas is flaky
Fixes
I worked on ... because ...
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>