Skip to content

Fixed data Assest lineage spec#27671

Open
Rohit0301 wants to merge 1 commit intomainfrom
fix-data-assest-lineage
Open

Fixed data Assest lineage spec#27671
Rohit0301 wants to merge 1 commit intomainfrom
fix-data-assest-lineage

Conversation

@Rohit0301
Copy link
Copy Markdown
Contributor

@Rohit0301 Rohit0301 commented Apr 23, 2026

Describe your changes:

Column level lineage test - test is getting timed out
data asset lineage spec - click in canvas is flaky

Fixes

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@Rohit0301 Rohit0301 self-assigned this Apr 23, 2026
@Rohit0301 Rohit0301 requested a review from a team as a code owner April 23, 2026 14:08
@Rohit0301 Rohit0301 added the safe to test Add this label to run secure Github workflows on PRs label Apr 23, 2026
Comment thread openmetadata-ui/src/main/resources/ui/playwright/utils/lineage.ts
@gitar-bot
Copy link
Copy Markdown

gitar-bot Bot commented Apr 23, 2026

Code Review ✅ Approved 1 resolved / 1 findings

Updates the data asset lineage specification for improved accuracy. No issues found.

✅ 1 resolved
Quality: dispatchEvent('click') bypasses Playwright actionability checks

📄 openmetadata-ui/src/main/resources/ui/playwright/utils/lineage.ts:514-516
Using dispatchEvent('click') instead of .click() bypasses Playwright's built-in actionability checks (e.g., ensuring the element is not obscured by overlays, is enabled, etc.). While this works around a flaky test, it may mask real UI issues where the button is covered or not truly interactive. The explicit waitFor({ state: 'visible' }) only partially compensates — visibility doesn't guarantee the element is unobscured or clickable.

Consider using .click({ force: true }) instead, which still uses Playwright's click mechanism but skips the actionability checks. Alternatively, investigate why the standard .click() was failing (e.g., an overlay or animation) and fix the root cause.

Options

Display: compact → Showing less information.

Comment with these commands to change:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@github-actions
Copy link
Copy Markdown
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 61%
61.98% (61732/99597) 42.09% (32990/78372) 45.14% (9763/21626)

@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants