Skip to content

Fix #27641: using sql alchemy rows old-style#27643

Open
edg956 wants to merge 1 commit intomainfrom
issue-27641
Open

Fix #27641: using sql alchemy rows old-style#27643
edg956 wants to merge 1 commit intomainfrom
issue-27641

Conversation

@edg956
Copy link
Copy Markdown
Contributor

@edg956 edg956 commented Apr 22, 2026

Describe your changes:

Fixes #27641

I applied a missing change after upgrading to SQL Alchemy 2.0, because the previous syntax to build dicts from Rows change from dict(row) to dict(row._asdict())

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Summary by Gitar

  • Testing:
    • Added test_it_turns_sql_alchemy_response_to_snowflake_query_log_entries to verify correct parsing of query log results.

This will update automatically on new commits.

This is because after ugprading to SQL Alchemy 2.0 the previous syntax to build `dict`s from `Row`s change from `dict(row)` to `dict(row._asdict())`
@edg956 edg956 requested a review from a team as a code owner April 22, 2026 19:15
@edg956 edg956 added Ingestion safe to test Add this label to run secure Github workflows on PRs labels Apr 22, 2026
@sonarqubecloud
Copy link
Copy Markdown

@github-actions
Copy link
Copy Markdown
Contributor

🔴 Playwright Results — 1 failure(s), 12 flaky

✅ 3698 passed · ❌ 1 failed · 🟡 12 flaky · ⏭️ 89 skipped

Shard Passed Failed Flaky Skipped
✅ Shard 1 481 0 0 4
🟡 Shard 2 654 0 2 7
🟡 Shard 3 663 0 3 1
🟡 Shard 4 647 0 1 27
✅ Shard 5 611 0 0 42
🔴 Shard 6 642 1 6 8

Genuine Failures (failed on all attempts)

Pages/Lineage/DataAssetLineage.spec.ts › verify create lineage for entity - Api Endpoint (shard 6)
�[31mTest timeout of 420000ms exceeded.�[39m
🟡 12 flaky test(s) (passed on retry)
  • Features/BulkEditEntity.spec.ts › Glossary (shard 2, 1 retry)
  • Features/Glossary/GlossaryHierarchy.spec.ts › should cancel move operation (shard 2, 1 retry)
  • Features/LandingPageWidgets/DomainDataProductsWidgets.spec.ts › Data Product asset count should update when assets are removed (shard 3, 1 retry)
  • Features/RTL.spec.ts › Verify Following widget functionality (shard 3, 1 retry)
  • Flow/PersonaFlow.spec.ts › Set default persona for team should work properly (shard 3, 1 retry)
  • Pages/Customproperties-part2.spec.ts › entityReferenceList shows item count, scrollable list, no expand toggle (shard 4, 1 retry)
  • Features/AutoPilot.spec.ts › Agents created by AutoPilot should be deleted (shard 6, 1 retry)
  • Pages/Lineage/LineageFilters.spec.ts › Verify lineage schema filter selection (shard 6, 1 retry)
  • Pages/Lineage/LineageRightPanel.spec.ts › Verify custom properties tab IS visible for supported type: searchIndex (shard 6, 1 retry)
  • Pages/Lineage/PlatformLineage.spec.ts › Verify domain platform view (shard 6, 1 retry)
  • Pages/Users.spec.ts › Permissions for table details page for Data Consumer (shard 6, 1 retry)
  • Pages/Users.spec.ts › Check permissions for Data Steward (shard 6, 1 retry)

📦 Download artifacts

How to debug locally
# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ingestion safe to test Add this label to run secure Github workflows on PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bad SQL Alchemy Row conversion breaks Snowflake's system metric profiling

2 participants