fix(advanced-search): move entityStatus to common config with hard-coded list values#27642
Conversation
Code Review ✅ ApprovedMoves entityStatus to the common configuration with hard-coded list values to standardize search parameters. No issues found. OptionsDisplay: compact → Showing less information. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | Gitar |
Contributor
🔴 Playwright Results — 5 failure(s), 11 flaky✅ 3698 passed · ❌ 5 failed · 🟡 11 flaky · ⏭️ 89 skipped
Genuine Failures (failed on all attempts)❌
|
Contributor
❌ UI Checkstyle Failed❌ Playwright — ESLint + Prettier + Organise ImportsOne or more Playwright test files have linting or formatting issues. Affected files
Fix locally (fast — only checks files changed in this branch): make ui-checkstyle-changed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes:
Renamed EntityFields.GLOSSARY_TERM_STATUS → EntityFields.ENTITY_STATUS since the field is not glossary-specific
Moved the entityStatus field from glossaryTermQueryBuilderFields into getCommonConfig() so the Status filter is available across all entity types in Advanced Search, not just Glossary Terms
Replaced the asyncFetch (which only queried the glossaryTerm index) with hard-coded listValues derived from the EntityStatus enum — eliminating the incorrect index-scoped API call entirely
Added E2E Playwright tests covering:
All EntityStatus enum values appear in the Status dropdown
Filtering by Status == shows the matching entity and hides others across different entity types (GlossaryTerm, MlModel, DataProduct)
Filtering by Status != excludes the matched entity and shows all others
Fixes #27570
I worked on ... because ...
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>