Skip to content

fix(advanced-search): move entityStatus to common config with hard-coded list values#27642

Open
Rohit0301 wants to merge 2 commits intomainfrom
fix-27570
Open

fix(advanced-search): move entityStatus to common config with hard-coded list values#27642
Rohit0301 wants to merge 2 commits intomainfrom
fix-27570

Conversation

@Rohit0301
Copy link
Copy Markdown
Contributor

Describe your changes:

Renamed EntityFields.GLOSSARY_TERM_STATUS → EntityFields.ENTITY_STATUS since the field is not glossary-specific
Moved the entityStatus field from glossaryTermQueryBuilderFields into getCommonConfig() so the Status filter is available across all entity types in Advanced Search, not just Glossary Terms
Replaced the asyncFetch (which only queried the glossaryTerm index) with hard-coded listValues derived from the EntityStatus enum — eliminating the incorrect index-scoped API call entirely
Added E2E Playwright tests covering:
All EntityStatus enum values appear in the Status dropdown
Filtering by Status == shows the matching entity and hides others across different entity types (GlossaryTerm, MlModel, DataProduct)
Filtering by Status != excludes the matched entity and shows all others

Fixes #27570

I worked on ... because ...

Screenshot 2026-04-23 at 12 10 43 AM

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@Rohit0301 Rohit0301 self-assigned this Apr 22, 2026
@Rohit0301 Rohit0301 requested a review from a team as a code owner April 22, 2026 18:45
@Rohit0301 Rohit0301 added safe to test Add this label to run secure Github workflows on PRs To release Will cherry-pick this PR into the release branch labels Apr 22, 2026
@gitar-bot
Copy link
Copy Markdown

gitar-bot Bot commented Apr 22, 2026

Code Review ✅ Approved

Moves entityStatus to the common configuration with hard-coded list values to standardize search parameters. No issues found.

Options

Display: compact → Showing less information.

Comment with these commands to change:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@github-actions
Copy link
Copy Markdown
Contributor

🔴 Playwright Results — 5 failure(s), 11 flaky

✅ 3698 passed · ❌ 5 failed · 🟡 11 flaky · ⏭️ 89 skipped

Shard Passed Failed Flaky Skipped
✅ Shard 1 481 0 0 4
🔴 Shard 2 650 5 2 7
🟡 Shard 3 667 0 1 1
🟡 Shard 4 645 0 3 27
✅ Shard 5 611 0 0 42
🟡 Shard 6 644 0 5 8

Genuine Failures (failed on all attempts)

Features/AdvancedSearch.spec.ts › Verify All conditions for Status field (shard 2)
�[31mTest timeout of 180000ms exceeded.�[39m
Features/AdvancedSearch.spec.ts › Verify Rule functionality for field Status with AND operator (shard 2)
�[31mTest timeout of 180000ms exceeded.�[39m
Features/AdvancedSearch.spec.ts › Verify Group functionality for field Status with AND operator (shard 2)
�[31mTest timeout of 180000ms exceeded.�[39m
Features/AdvancedSearch.spec.ts › Verify Rule functionality for field Status with OR operator (shard 2)
�[31mTest timeout of 180000ms exceeded.�[39m
Features/AdvancedSearch.spec.ts › Verify Group functionality for field Status with OR operator (shard 2)
�[31mTest timeout of 180000ms exceeded.�[39m
🟡 11 flaky test(s) (passed on retry)
  • Features/BulkEditEntity.spec.ts › Database Schema (shard 2, 1 retry)
  • Features/BulkEditEntity.spec.ts › Glossary (shard 2, 1 retry)
  • Features/RTL.spec.ts › Verify Following widget functionality (shard 3, 1 retry)
  • Pages/Customproperties-part2.spec.ts › entityReferenceList shows item count, scrollable list, no expand toggle (shard 4, 1 retry)
  • Pages/DataContracts.spec.ts › Create Data Contract and validate for Api Collection (shard 4, 1 retry)
  • Pages/Entity.spec.ts › Tier Add, Update and Remove (shard 4, 1 retry)
  • Pages/Lineage/DataAssetLineage.spec.ts › Column lineage for dashboard -> dashboard (shard 6, 1 retry)
  • Pages/Lineage/LineageFilters.spec.ts › Verify lineage schema filter selection (shard 6, 1 retry)
  • Pages/Lineage/LineageRightPanel.spec.ts › Verify custom properties tab is NOT visible for dashboardService in platform lineage (shard 6, 1 retry)
  • Pages/Lineage/PlatformLineage.spec.ts › Verify domain platform view (shard 6, 1 retry)
  • Pages/Users.spec.ts › Permissions for table details page for Data Consumer (shard 6, 1 retry)

📦 Download artifacts

How to debug locally
# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

@github-actions
Copy link
Copy Markdown
Contributor

❌ UI Checkstyle Failed

❌ Playwright — ESLint + Prettier + Organise Imports

One or more Playwright test files have linting or formatting issues.

Affected files
  • openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/AdvancedSearch.spec.ts
    • openmetadata-ui/src/main/resources/ui/playwright/utils/advancedSearch.ts

Fix locally (fast — only checks files changed in this branch):

make ui-checkstyle-changed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs To release Will cherry-pick this PR into the release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Explore Advance filter for Data Assets Status only shows GlossaryTerm statuses

1 participant