Skip to content

Fix Healthcheck for vector embedding#27616

Open
mohityadav766 wants to merge 1 commit intomainfrom
fix-healtcheck
Open

Fix Healthcheck for vector embedding#27616
mohityadav766 wants to merge 1 commit intomainfrom
fix-healtcheck

Conversation

@mohityadav766
Copy link
Copy Markdown
Member

@mohityadav766 mohityadav766 commented Apr 22, 2026

Fixes #27614


Summary by Gitar

  • Logic fix:
    • Updated findMissingIndexes to skip the vectorEmbedding index check when semantic search is disabled.
  • Testing:
    • Added SystemRepositoryMissingIndexesTest to verify index validation logic under various semantic search configurations.

This will update automatically on new commits.

@mohityadav766 mohityadav766 self-assigned this Apr 22, 2026
Copilot AI review requested due to automatic review settings April 22, 2026 07:25
@github-actions github-actions Bot added backend safe to test Add this label to run secure Github workflows on PRs labels Apr 22, 2026
@gitar-bot
Copy link
Copy Markdown

gitar-bot Bot commented Apr 22, 2026

Code Review ✅ Approved

Updates the healthcheck logic for vector embedding to ensure accurate service status reporting. No issues found.

Options

Display: compact → Showing less information.

Comment with these commands to change:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses a healthcheck false-negative where the search validation reported the vectorEmbedding index as missing even when semantic search (vector embeddings) is disabled, aligning behavior with issue #27614.

Changes:

  • Skip vectorEmbedding index existence checks when SearchRepository.isVectorEmbeddingEnabled() is false.
  • Expose findMissingIndexes for unit testing via @VisibleForTesting + package-private visibility.
  • Add focused unit tests covering the missing-index behavior with semantic search on/off.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
openmetadata-service/src/main/java/org/openmetadata/service/jdbi3/SystemRepository.java Updates search healthcheck missing-index detection to ignore vectorEmbedding when semantic search is disabled.
openmetadata-service/src/test/java/org/openmetadata/service/jdbi3/SystemRepositoryMissingIndexesTest.java Adds unit tests verifying missing-index behavior for vectorEmbedding under enabled/disabled semantic search configurations.

@sonarqubecloud
Copy link
Copy Markdown

@github-actions
Copy link
Copy Markdown
Contributor

🟡 Playwright Results — all passed (16 flaky)

✅ 3695 passed · ❌ 0 failed · 🟡 16 flaky · ⏭️ 89 skipped

Shard Passed Failed Flaky Skipped
🟡 Shard 1 480 0 1 4
🟡 Shard 2 653 0 3 7
✅ Shard 3 666 0 0 1
🟡 Shard 4 643 0 5 27
🟡 Shard 5 610 0 1 42
🟡 Shard 6 643 0 6 8
🟡 16 flaky test(s) (passed on retry)
  • Pages/Customproperties-part1.spec.ts › no duplicate card after update (shard 1, 1 retry)
  • Features/BulkEditEntity.spec.ts › Glossary (shard 2, 1 retry)
  • Features/DomainTierCertificationVoting.spec.ts › DataProduct - Tier assign, update, and remove (shard 2, 1 retry)
  • Features/Glossary/GlossaryP3Tests.spec.ts › should handle multiple rapid API calls (shard 2, 1 retry)
  • Pages/Customproperties-part2.spec.ts › entityReferenceList shows item count, scrollable list, no expand toggle (shard 4, 1 retry)
  • Pages/DataContracts.spec.ts › Create Data Contract and validate for Spreadsheet (shard 4, 1 retry)
  • Pages/DataContractsSemanticRules.spec.ts › Validate DisplayName Rule Any_In (shard 4, 1 retry)
  • Pages/DomainUIInteractions.spec.ts › Add owner to data product via UI (shard 4, 1 retry)
  • Pages/Entity.spec.ts › Delete Ml Model (shard 4, 1 retry)
  • Pages/Glossary.spec.ts › Add and Remove Assets (shard 5, 1 retry)
  • Pages/Lineage/DataAssetLineage.spec.ts › verify create lineage for entity - Worksheet (shard 6, 1 retry)
  • Pages/Lineage/LineageFilters.spec.ts › Verify lineage schema filter selection (shard 6, 1 retry)
  • Pages/Lineage/LineageRightPanel.spec.ts › Verify custom properties tab IS visible for supported type: searchIndex (shard 6, 1 retry)
  • Pages/Lineage/PlatformLineage.spec.ts › Verify domain platform view (shard 6, 1 retry)
  • Pages/Teams.spec.ts › Teams Page Flow (shard 6, 1 retry)
  • Pages/Users.spec.ts › Permissions for table details page for Data Consumer (shard 6, 1 retry)

📦 Download artifacts

How to debug locally
# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend safe to test Add this label to run secure Github workflows on PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Healtcheck Endpoint Running into Issues with Vector Emedding when Seamantic search is disabled

3 participants