Conversation
Code Review ✅ ApprovedUpdates the healthcheck logic for vector embedding to ensure accurate service status reporting. No issues found. OptionsDisplay: compact → Showing less information. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | Gitar |
There was a problem hiding this comment.
Pull request overview
This PR addresses a healthcheck false-negative where the search validation reported the vectorEmbedding index as missing even when semantic search (vector embeddings) is disabled, aligning behavior with issue #27614.
Changes:
- Skip
vectorEmbeddingindex existence checks whenSearchRepository.isVectorEmbeddingEnabled()isfalse. - Expose
findMissingIndexesfor unit testing via@VisibleForTesting+ package-private visibility. - Add focused unit tests covering the missing-index behavior with semantic search on/off.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| openmetadata-service/src/main/java/org/openmetadata/service/jdbi3/SystemRepository.java | Updates search healthcheck missing-index detection to ignore vectorEmbedding when semantic search is disabled. |
| openmetadata-service/src/test/java/org/openmetadata/service/jdbi3/SystemRepositoryMissingIndexesTest.java | Adds unit tests verifying missing-index behavior for vectorEmbedding under enabled/disabled semantic search configurations. |
|
🟡 Playwright Results — all passed (16 flaky)✅ 3695 passed · ❌ 0 failed · 🟡 16 flaky · ⏭️ 89 skipped
🟡 16 flaky test(s) (passed on retry)
How to debug locally# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip # view trace |



Fixes #27614
Summary by Gitar
findMissingIndexesto skip thevectorEmbeddingindex check when semantic search is disabled.SystemRepositoryMissingIndexesTestto verify index validation logic under various semantic search configurations.This will update automatically on new commits.