Skip to content

Conversation

@aji-aju
Copy link
Contributor

@aji-aju aji-aju commented Jan 8, 2026

Describe your changes:

Fixes

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Summary by Gitar

  • Schema compliance fix:
    • Removed deprecated authorityUrl field from samlConfiguration.idp in openmetadata-mcp/src/test/resources/test-config-mcp.yaml
  • Alignment with JSON schema:
    • SAML schema (samlSSOClientConfig.json) has additionalProperties: false and never included authorityUrl
  • Database migration context:
    • Corresponds to existing migration (v1115/MigrationUtil.java) that removes this field from production configs

This will update automatically on new commits.


@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2026

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@aji-aju aji-aju added safe to test Add this label to run secure Github workflows on PRs To release Will cherry-pick this PR into the release branch backend labels Jan 8, 2026
@gitar-bot
Copy link

gitar-bot bot commented Jan 8, 2026

🔍 CI failure analysis for 777dcfa: All CI failures are due to missing 'safe to test' label, not related to code changes. The PR correctly removes a deprecated field from test configuration.

Issue

All CI jobs failed at the PR label validation step before any actual tests or validations could run.

Root Cause

The PR is missing the required safe to test label, which is a repository workflow control mechanism. The validation step checks for this label before proceeding with any CI execution:

Error! This pull request does not contain any of the valid labels: ['safe to test']

Details

Affected Jobs

  • validate-json-yaml (Job ID: 59779501794)
  • All 6 Playwright CI jobs (Jobs: 59779501853, 59779501855, 59779501852, 59779501876, 59779501845, 59779501831)

Why These Failures Are Unrelated to Code Changes

This PR removes a single line from openmetadata-mcp/src/test/resources/test-config-mcp.yaml:

authorityUrl: ""  # REMOVED

This change is actually correct and expected because:

  1. The SAML JSON schema (samlSSOClientConfig.json) explicitly has "additionalProperties": false for the IDP configuration
  2. The schema only defines these valid IDP fields: entityId, ssoLoginUrl, idpX509Certificate, nameId
  3. authorityUrl was never part of the official schema and is deprecated
  4. A database migration already exists (v1115/MigrationUtil.java) that removes this field from production configurations
  5. The field had an empty value, so no functional data was lost

Evidence

From the validate-json-yaml job logs (line 297):

Error! This pull request does not contain any of the valid labels: ['safe to test']
This pull request does not contain invalid labels
Exiting with an error code

The job exits before running any YAML/JSON validation. Similarly, all Playwright jobs exit at the same label check step without executing any tests.

Code Review ✅ Approved

Clean removal of deprecated authorityUrl field from test config to align with SAML schema that has additionalProperties: false.

Tip

Comment Gitar fix CI or enable auto-apply: gitar auto-apply:on

Options

Auto-apply is off Gitar will not commit updates to this branch.
Display: compact Hiding non-applicable rules.

Comment with these commands to change:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | This comment will update automatically (Docs)

@pmbrull pmbrull merged commit 29b45c2 into main Jan 8, 2026
38 of 48 checks passed
@pmbrull pmbrull deleted the saml_remove_authority branch January 8, 2026 09:55
@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2026

Changes have been cherry-picked to the 1.11.5 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend safe to test Add this label to run secure Github workflows on PRs To release Will cherry-pick this PR into the release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants