-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Remove saml authorityUrl from mcp Config #25138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
🔍 CI failure analysis for 777dcfa: All CI failures are due to missing 'safe to test' label, not related to code changes. The PR correctly removes a deprecated field from test configuration.IssueAll CI jobs failed at the PR label validation step before any actual tests or validations could run. Root CauseThe PR is missing the required DetailsAffected Jobs
Why These Failures Are Unrelated to Code ChangesThis PR removes a single line from authorityUrl: "" # REMOVEDThis change is actually correct and expected because:
EvidenceFrom the validate-json-yaml job logs (line 297): The job exits before running any YAML/JSON validation. Similarly, all Playwright jobs exit at the same label check step without executing any tests. Code Review ✅ ApprovedClean removal of deprecated Tip Comment OptionsAuto-apply is off Gitar will not commit updates to this branch. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | This comment will update automatically (Docs) |
|
Changes have been cherry-picked to the 1.11.5 branch. |
(cherry picked from commit 29b45c2)
Describe your changes:
Fixes
I worked on ... because ...
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>Summary by Gitar
authorityUrlfield fromsamlConfiguration.idpinopenmetadata-mcp/src/test/resources/test-config-mcp.yamlsamlSSOClientConfig.json) hasadditionalProperties: falseand never includedauthorityUrlv1115/MigrationUtil.java) that removes this field from production configsThis will update automatically on new commits.