Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 7, 2026

Describe your changes:

Long usernames and display names in the Users table were overlapping into adjacent columns without truncation or tooltips, as shown below where "boldd8a78d20.hawkaf61caf3.176" runs into "Boldd8a78d20Hawkaf61caf3":

Changes:

  • Added width: 200 and ellipsis: { showTitle: false } to Username and Name columns in commonUserDetailColumns()
  • Username column uses existing userCellRenderer function (with UserPopOverCard)
  • Name column renders using getEntityName(record) directly

This centralized fix applies to all user tables: Settings → Users/Admins, Online Users, and Team User tabs.

Implementation:

{
  title: t('label.username'),
  dataIndex: 'username',
  key: 'username',
  width: 200,
  ellipsis: { showTitle: false },
  render: (_, record) => userCellRenderer(record),
},
{
  title: t('label.name'),
  dataIndex: 'name',
  key: 'name',
  width: 200,
  ellipsis: { showTitle: false },
  render: (_, record) => getEntityName(record),
}

The column-level ellipsis configuration enables Ant Design Table's built-in text truncation with automatic tooltip on hover, following the pattern from EntityLineageUtils.tsx.

Type of change:

  • Bug fix

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.
Original prompt

This section details on the original issue you should resolve

<issue_title>Text overlapping in Users table</issue_title>
<issue_description>Image

It should have an ellipsis with a tooltip</issue_description>

Comments on the Issue (you are @copilot in this section)


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

- Add Typography component to imports
- Set width property (200px) for Username and Name columns
- Add ellipsis config with showTitle: false at column level
- Use Typography.Text with ellipsis tooltip for Name column
- Keep UserPopOverCard with showUserName for Username column
- Wrap fallback getEntityName with Typography.Text for ellipsis

Co-authored-by: karanh37 <33024356+karanh37@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix text overlapping issue in Users table Fix text overlapping in Users table columns Jan 7, 2026
Copilot AI requested a review from karanh37 January 7, 2026 13:11
Comment on lines 48 to 61
width: 200,
ellipsis: { showTitle: false },
render: (_, record) =>
record.name ? (
<UserPopOverCard
showUserName
profileWidth={16}
userName={record.name}
/>
) : (
<Typography.Text ellipsis={{ tooltip: true }}>
{getEntityName(record)}
</Typography.Text>
),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix this to userCellRenderer instead adding custom rendering here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in commit 16e6000 - now using the existing userCellRenderer function instead of duplicating the logic inline.

Comment on lines 69 to 72
render: (_, record) => (
<Typography.Text ellipsis={{ tooltip: true }}>
{getEntityName(record)}
</Typography.Text>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding ellipsis to column options should be good. no need to double the ellipsis in the render too

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in commit 16e6000 - removed the Typography.Text wrapper. The column-level ellipsis configuration is now sufficient for text truncation with tooltip.

@chirag-madlani
Copy link
Collaborator

@copilot address comments

…llipsis

- Use existing userCellRenderer function for Username column instead of duplicating logic
- Remove Typography.Text wrapper from Name column (column-level ellipsis is sufficient)
- Remove unused Typography import

Co-authored-by: chirag-madlani <12962843+chirag-madlani@users.noreply.github.com>
@gitar-bot
Copy link

gitar-bot bot commented Jan 8, 2026

Code Review ✅ Approved

Clean, minimal bug fix that adds proper text truncation to prevent column overlapping in the Users table. The implementation follows existing patterns in the codebase.

Options

Auto-apply is off Gitar will not commit updates to this branch.
Display: compact Hiding non-applicable rules.

Comment with these commands to change:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | This comment will update automatically (Docs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Text overlapping in Users table

3 participants