-
Notifications
You must be signed in to change notification settings - Fork 1.6k
AI #200 - Add TRIGGER permission to application bots #25113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
gitar auto-apply:on |
|
gitar can you apply your suggestion? |
Co-authored-by: pmbrull <pmbrull@users.noreply.github.com>
Applied the suggestion! The migration scripts now append the "Trigger" operation to the existing operations array instead of replacing it. Changes made:
This preserves any custom operations that may have been added to the ApplicationBotPolicy while still adding the new Trigger permission. |
🔍 CI failure analysis for 86ceee3: Maven SonarCloud timeout after 3.5 hours, Maven PostgreSQL timeout after 2.75 hours - both infrastructure issues. Plus Playwright (96.8-98.5% pass) and Python (99.97% pass) flaky tests - all unrelated to PR.IssueMaven SonarCloud Job (59933446213): Maven PostgreSQL Job (59933446360): Failed after ~2.75 hours. Playwright Jobs: Multiple shards with flaky tests (96.8-98.5% pass rates). Python Job: 1 failed test (99.97% pass rate). Root CauseMaven Jobs (SonarCloud & PostgreSQL)Both Maven jobs failed after extended runtimes (2.75-3.5 hours) with inaccessible logs. This is the same pattern documented multiple times:
Consistent indicators of:
Not code problems that can be fixed in this PR. Previous Failures (Documented)
DetailsAll failures are completely unrelated to this PR's ApplicationBotPolicy changes: This PR only modifies:
None of these changes affect:
The changes are minimal configuration updates (JSON + SQL) that:
The repeated pattern of Maven timeouts at 2.75-3.5 hours, combined with high test pass rates (96.8-99.97%) in unrelated features, definitively indicates CI infrastructure problems, not code defects. Code Review ✅ ApprovedClean, well-implemented PR that adds Trigger permission to ApplicationBotPolicy with idempotent migrations for both MySQL and PostgreSQL. Resolved ✅ 1 resolvedEdge Case: Migration overwrites custom operations if policy was modified
What Works WellBoth SQL migrations use proper idempotency patterns - checking for existing values before appending, and validating the JSON path exists before modification. Options ✅ Auto-apply✅ Auto-apply is on Gitar will commit updates to this branch. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | This comment will update automatically (Docs) |



Describe your changes:
Add trigger permission to application bots. This is used in collate for /run in Dynamic Agents
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>Summary by Gitar
Triggeroperation toApplicationBotPolicy.jsonenabling application bots to trigger agent runsApplicationBotPolicyrecords inpolicy_entitytable/v1/apps/trigger/{name}endpoint with proper bot permissionsThis will update automatically on new commits.