chore(test): run all test suites, not just test/*.test.ts#72
Open
stealthwhizz wants to merge 1 commit into
Open
chore(test): run all test suites, not just test/*.test.ts#72stealthwhizz wants to merge 1 commit into
stealthwhizz wants to merge 1 commit into
Conversation
The test script globbed only test/*.test.ts, so suites under src/**/__tests__/ (memory, sandbox-memory, skill-learner, task-tracker) and src/__tests__/ were never executed by `npm test`. Those files are currently it.todo() stubs, so they surface as TODO markers rather than failures — but wiring them in means any real tests added there from now on actually run in CI. Switch to recursive globs covering both locations. Suite: 27 pass, 18 todo, 0 fail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The test script globbed only
test/*.test.ts:So the suites under
src/**/__tests__/(memory, sandbox-memory, skill-learner, task-tracker) andsrc/__tests__/telemetry.test.tswere never executed bynpm testor CI — silently non-running tests.What I checked first
Ran those orphaned files directly. They're currently
it.todo(...)placeholder stubs with no bodies, so they report as TODO markers, not failures. That means flipping the glob is safe today (CI stays green) and, more importantly, any real tests added under those paths from now on will actually run instead of being silently ignored.Fix
Recursive globs covering both locations.
Result
npm testnow discovers every suite:27 real tests pass, 18 TODO stubs surface as TODO (not failures), 0 failures.
Follow-up flagged from #71; kept as its own one-line change.