Skip to content

fix(terminal): prevent duplicate input on shell restart #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tsj2003 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(terminal): prevent duplicate input on shell restart #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/terminal.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ export class TerminalManager {
readonly xterm: Terminal;
private readonly fitAddon: FitAddon;
private resizeObserver: ResizeObserver | null = null;
private dataHandler: ((data: string) => void) | null = null;

constructor() {
this.xterm = new Terminal({
Expand Down Expand Up @@ -39,6 +40,11 @@ export class TerminalManager {

this.fitAddon = new FitAddon();
this.xterm.loadAddon(this.fitAddon);

// Register onData once in constructor to prevent duplicate handlers on restart
this.xterm.onData((data: string) => {
this.dataHandler?.(data);
});
}

/** Mount the terminal into a DOM element and start auto-resize. */
Expand All @@ -61,9 +67,11 @@ export class TerminalManager {
this.xterm.write(data);
}

/** Register a handler for user keystrokes (sent to shell stdin). */
/** Register a handler for user keystrokes (sent to shell stdin).
* Only one handler can be registered at a time; subsequent calls replace the previous handler.
*/
onData(handler: (data: string) => void): void {
this.xterm.onData(handler);
this.dataHandler = handler;
}

/** Current terminal dimensions for pty resize. */
Expand Down