fix(flagd-provider): update fractional targeting test expectations for flagd v0.15.4#166
fix(flagd-provider): update fractional targeting test expectations for flagd v0.15.4#166jonathannorris wants to merge 5 commits into
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the expected hex color values in the flagd provider's test suite for fractional targeting. Feedback suggests that the updated expectations are less effective because most keys now resolve to the default variant, making it difficult to verify if the fractional logic is functioning correctly or simply falling back to defaults. It is recommended to use targeting keys that map to a more diverse set of variants to ensure proper test coverage.
…r flagd v0.15.4 The fractional evaluator bucketing algorithm changed in flagd v0.15.4 (high-precision integer math replacing float-based bucketing), causing all color-palette-experiment assignments to shift. Updated expected values verified against the twmb/murmur3 + distributeValue logic used by flagd v0.15.4. Closes #73 Signed-off-by: Jonathan Norris <jonathan.norris@dynatrace.com>
…al test Signed-off-by: Jonathan Norris <jonathan.norris@dynatrace.com>
980a417 to
50386f8
Compare
Signed-off-by: Jonathan Norris <jonathan.norris@dynatrace.com>
Signed-off-by: Jonathan Norris <jonathan.norris@dynatrace.com>
|
is failing due to a Ruby 4.1dev regression — a commit between May 4–12 made The fix is already in bundler master ( |
Summary
color-palette-experimentfractional targeting test expectations to match bucketing behavior in flagdv0.15.4(hash * totalWeight) >> 32), which rebucketed all users — tracked in [flagd] [FEATURE] Harden Hashing Consistency And Add Support For Non-string Attributes in Fractional Evaluation #73twmb/murmur3+distributeValuealgorithm from flagd's source atcore/v0.15.4Also bumps
BUNDLED WITHin the otel-hookGemfile.lockfrom 2.7.1 to 4.0.11. A Ruby 4.1dev commit (between May 4–12) madePathname::SEPARATOR_PATprivate, breaking bundler 2.7.1's vendored thor. Bundler 4.0.0+ includes the fix (ruby/rubygems#9056).