Skip to content

Conversation

@federicobond
Copy link
Member

@federicobond federicobond commented Dec 13, 2025

This should fix the build errors in the immediate, but I haven't done more research on what a better constraint should be for long-term reliability.

Signed-off-by: Federico Bond <federicobond@gmail.com>
@federicobond federicobond requested review from a team as code owners December 13, 2025 00:23
@gemini-code-assist
Copy link

Summary of Changes

Hello @federicobond, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request aims to fix existing build errors by updating the protobuf dependency to a more recent and compatible version. The change specifically targets the openfeature-provider-flagd component, ensuring that the build process can complete successfully with the updated dependency.

Highlights

  • Protobuf Version Bump: The protobuf package version has been updated from 5.26.1 to 5.29.5 across the project's dependency configurations to resolve build errors.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@codecov
Copy link

codecov bot commented Dec 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.56%. Comparing base (97a5717) to head (061ed36).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #327   +/-   ##
=======================================
  Coverage   94.56%   94.56%           
=======================================
  Files          22       22           
  Lines        1068     1068           
=======================================
  Hits         1010     1010           
  Misses         58       58           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the protobuf dependency to version 5.29.5 to fix build errors. The changes are correctly applied to pyproject.toml for the openfeature-provider-flagd provider and the uv.lock file. My review includes a suggestion to improve the dependency specification for protobuf to enhance stability for downstream users by using a compatible release specifier, which will prevent potential issues with future releases.

Copy link
Member

@gruebel gruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have another PR open to support Python 3.14, which needs to bump protobuf even higher. So, let's go with this for now.

@federicobond
Copy link
Member Author

Ah sorry, must have missed that. Will review yours after this merge.

@federicobond federicobond merged commit 223a903 into main Dec 13, 2025
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants