-
Notifications
You must be signed in to change notification settings - Fork 24
fix(build): bump protobuf package version to a compatible version #327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Federico Bond <federicobond@gmail.com>
Summary of ChangesHello @federicobond, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request aims to fix existing build errors by updating the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #327 +/- ##
=======================================
Coverage 94.56% 94.56%
=======================================
Files 22 22
Lines 1068 1068
=======================================
Hits 1010 1010
Misses 58 58 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the protobuf dependency to version 5.29.5 to fix build errors. The changes are correctly applied to pyproject.toml for the openfeature-provider-flagd provider and the uv.lock file. My review includes a suggestion to improve the dependency specification for protobuf to enhance stability for downstream users by using a compatible release specifier, which will prevent potential issues with future releases.
gruebel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have another PR open to support Python 3.14, which needs to bump protobuf even higher. So, let's go with this for now.
|
Ah sorry, must have missed that. Will review yours after this merge. |
This should fix the build errors in the immediate, but I haven't done more research on what a better constraint should be for long-term reliability.