fix(flagd): add logging for invalid env var parsing failures#1790
Open
IshitaSharma08 wants to merge 2 commits into
Open
fix(flagd): add logging for invalid env var parsing failures#1790IshitaSharma08 wants to merge 2 commits into
IshitaSharma08 wants to merge 2 commits into
Conversation
github-actions
Bot
requested review from
Kavindu-Dodan,
beeme1mr,
thisthat and
toddbaert
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates Config.java by reordering imports and adding error logging to the fallBackToEnvOrDefault method to improve observability when environment variable parsing fails. There are no review comments to address, and I have no further feedback to provide.
IshitaSharma08
changed the title
Signed-off-by: Ishita Sharma <Ishitasharma050306@gmail.com>
IshitaSharma08
force-pushed
the
add-env-var-error-logging
branch
from
f5072a5 to
1a8ad7e
Compare
chrfwow
reviewed
May 11, 2026
| import java.util.function.Function; | ||
| import java.util.stream.Collectors; | ||
|
|
||
| import dev.openfeature.contrib.providers.flagd.resolver.rpc.cache.CacheType; |
Contributor
There was a problem hiding this comment.
Moving this import violates a checkstyle rule and makes the CI pipeline build fail. Please revert it or run spotless:apply
Contributor
|
@IshitaSharma08 it seems like you forgot to sign-off at least one commit, that's why the DCO action fails. Please sign off your commits and force push them |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added error logging when environment variable parsing fails in Config.java.
Previously invalid environment variables silently fell back to default values without notifying the user.
This change logs the parsing failure before returning the default value.