Skip to content

Move central configuration info higher #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
martenrebane wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Move central configuration info higher #367

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
142 changes: 73 additions & 69 deletions app/src/main/kotlin/ee/ria/DigiDoc/fragment/screen/DiagnosticsScreen.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@ import ee.ria.DigiDoc.ui.component.shared.StatusSnackbarHost
import ee.ria.DigiDoc.ui.component.shared.TopBar
import ee.ria.DigiDoc.ui.theme.Dimensions.SPadding
import ee.ria.DigiDoc.ui.theme.Dimensions.XSPadding
import ee.ria.DigiDoc.ui.theme.Dimensions.zeroPadding
import ee.ria.DigiDoc.ui.theme.RIADigiDocTheme
import ee.ria.DigiDoc.ui.theme.buttonRoundCornerShape
import ee.ria.DigiDoc.utils.accessibility.AccessibilityUtil.Companion.getAccessibilityEventType
Expand Down Expand Up @@ -261,8 +262,12 @@ fun DiagnosticsScreen(
SettingsSwitchItem(
modifier =
modifier
.padding(XSPadding)
.semantics {
.padding(
start = XSPadding,
end = XSPadding,
top = XSPadding,
bottom = zeroPadding,
).semantics {
testTagsAsResourceId = true
}.testTag("mainDiagnosticsLogging"),
checked = enableOneTimeLogGeneration,
Expand Down Expand Up @@ -321,6 +326,72 @@ fun DiagnosticsScreen(
)
}

SpannableBoldText(
modifier = modifier,
stringResource(id = R.string.main_diagnostics_central_configuration_title),
"",
)
DiagnosticsText(
modifier =
modifier
.semantics {
testTagsAsResourceId = true
}.testTag("mainDiagnosticsCentralConfigurationDate"),
stringResource(id = R.string.main_diagnostics_date_title),
currentConfiguration?.metaInf?.date ?: "",
)
DiagnosticsText(
modifier =
modifier
.semantics {
testTagsAsResourceId = true
}.testTag("mainDiagnosticsCentralConfigurationSerial"),
stringResource(id = R.string.main_diagnostics_serial_title),
currentConfiguration?.metaInf?.serial.toString(),
)
DiagnosticsText(
modifier =
modifier
.semantics {
testTagsAsResourceId = true
}.testTag("mainDiagnosticsCentralConfigurationUrl"),
stringResource(id = R.string.main_diagnostics_url_title),
currentConfiguration?.metaInf?.url ?: "",
)
DiagnosticsText(
modifier =
modifier
.semantics {
testTagsAsResourceId = true
}.testTag("mainDiagnosticsCentralConfigurationVersion"),
stringResource(id = R.string.main_diagnostics_version_title),
currentConfiguration?.metaInf?.version.toString(),
)
DiagnosticsText(
modifier =
modifier
.semantics {
testTagsAsResourceId = true
}.testTag("mainDiagnosticsCentralConfigurationUpdateDate"),
stringResource(id = R.string.main_diagnostics_configuration_update_date),
diagnosticsViewModel.getConfigurationDate(currentConfiguration?.configurationUpdateDate),
)
DiagnosticsText(
modifier =
modifier
.semantics {
testTagsAsResourceId = true
}.testTag("mainDiagnosticsCentralConfigurationLastCheck"),
stringResource(id = R.string.main_diagnostics_configuration_last_check_date),
diagnosticsViewModel.getConfigurationDate(currentConfiguration?.configurationLastUpdateCheckDate),
)
HorizontalDivider(
modifier =
modifier
.fillMaxWidth()
.padding(horizontal = XSPadding)
.padding(top = SPadding),
)
SpannableBoldText(
modifier =
modifier
Expand Down Expand Up @@ -546,73 +617,6 @@ fun DiagnosticsScreen(
.padding(top = SPadding),
)
}
SpannableBoldText(
modifier = modifier,
stringResource(id = R.string.main_diagnostics_central_configuration_title),
"",
)
DiagnosticsText(
modifier =
modifier
.semantics {
testTagsAsResourceId = true
}.testTag("mainDiagnosticsCentralConfigurationDate"),
stringResource(id = R.string.main_diagnostics_date_title),
currentConfiguration?.metaInf?.date ?: "",
)
DiagnosticsText(
modifier =
modifier
.semantics {
testTagsAsResourceId = true
}.testTag("mainDiagnosticsCentralConfigurationSerial"),
stringResource(id = R.string.main_diagnostics_serial_title),
currentConfiguration?.metaInf?.serial.toString(),
)
DiagnosticsText(
modifier =
modifier
.semantics {
testTagsAsResourceId = true
}.testTag("mainDiagnosticsCentralConfigurationUrl"),
stringResource(id = R.string.main_diagnostics_url_title),
currentConfiguration?.metaInf?.url ?: "",
)
DiagnosticsText(
modifier =
modifier
.semantics {
testTagsAsResourceId = true
}.testTag("mainDiagnosticsCentralConfigurationVersion"),
stringResource(id = R.string.main_diagnostics_version_title),
currentConfiguration?.metaInf?.version.toString(),
)
DiagnosticsText(
modifier =
modifier
.semantics {
testTagsAsResourceId = true
}.testTag("mainDiagnosticsCentralConfigurationUpdateDate"),
stringResource(id = R.string.main_diagnostics_configuration_update_date),
diagnosticsViewModel.getConfigurationDate(currentConfiguration?.configurationUpdateDate),
)
DiagnosticsText(
modifier =
modifier
.semantics {
testTagsAsResourceId = true
}.testTag("mainDiagnosticsCentralConfigurationLastCheck"),
stringResource(id = R.string.main_diagnostics_configuration_last_check_date),
diagnosticsViewModel.getConfigurationDate(currentConfiguration?.configurationLastUpdateCheckDate),
)
HorizontalDivider(
modifier =
modifier
.fillMaxWidth()
.padding(horizontal = XSPadding)
.padding(top = SPadding),
)

if (openRestartConfirmationDialog.value) {
BasicAlertDialog(
modifier =
Expand Down
Loading