Make finding icon at runtime more robust.#1398
Merged
kristelmerilain merged 1 commit intoMay 20, 2026
Merged
Conversation
metsma
approved these changes
Apr 19, 2026
By default, the file name (argv[0]) of the application is used to compute its name, which can break if a distribution wraps the binary with a shell script to set some environment variables, as used in Guix for example. * client/main.cpp (main): Explicitly set the desktop file name. Signed-off-by: Maxim Cournoyer <maxim@guixotic.coop>
metsma
force-pushed
the
make-finding-icon-more-robust
branch
from
3504f61 to
6c8e245
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default, the file name (argv[0]) of the application is used to compute its name, which can break if a distribution wraps the binary with a shell script to set some environment variables, as used in Guix for example.
Signed-off-by: Maxim Cournoyer maxim@guixotic.coop