Skip to content

Remove invalid XML1.0 characters from Role/City... fields #1387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lauris71 wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Remove invalid XML1.0 characters from Role/City... fields #1387

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
28314fe
Remove invalid XML1.0 characters from Role/City... fields
Jan 2, 2026
a562d02
Use iterator
Jan 2, 2026
7c5d330
Use reserve/append instead of resize
Jan 2, 2026
334beaa
Merge branch 'open-eid:master' into master
lauris71 Jan 27, 2026
979b2cd
Use QValidator
metsma Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ jobs:
container: ubuntu:${{ matrix.container }}
strategy:
matrix:
container: ['22.04', '24.04', '25.04', '25.10']
container: ['22.04', '24.04', '25.10', '26.04']
arch: ['amd64', 'arm64']
env:
DEBIAN_FRONTEND: noninteractive
Expand Down Expand Up @@ -116,7 +116,7 @@ jobs:
container: fedora:${{ matrix.container }}
strategy:
matrix:
container: [42, 43]
container: [42, 43, 44]
steps:
- name: Download artifact
uses: dawidd6/action-download-artifact@v11
Expand Down
12 changes: 8 additions & 4 deletions client/dialogs/RoleAddressDialog.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,17 +37,20 @@ RoleAddressDialog::RoleAddressDialog(QWidget *parent)
d->buttonLayout->setDirection(QBoxLayout::RightToLeft);
#endif
setWindowFlags(Qt::Dialog | Qt::CustomizeWindowHint);
for(QLineEdit *w: findChildren<QLineEdit*>())
w->setAttribute(Qt::WA_MacShowFocusRect, false);

connect( d->cancel, &QPushButton::clicked, this, &RoleAddressDialog::reject );
connect( d->sign, &QPushButton::clicked, this, &RoleAddressDialog::accept );

auto *validator = new QRegularExpressionValidator(
QRegularExpression(QStringLiteral("[^\\x00-\\x08\\x0B\\x0C\\x0E-\\x1F\\uFFFE\\uFFFF]*")),
this);
auto list = findChildren<QLineEdit*>();
if(!list.isEmpty())
list.first()->setFocus();
for(QLineEdit *line: list)
{
line->setAttribute(Qt::WA_MacShowFocusRect, false);
line->setValidator(validator);
Settings::Option<QStringList> s{line->objectName(), {}};
auto *completer = new QCompleter(s, line);
completer->setMaxVisibleItems(10);
Expand All @@ -57,8 +60,9 @@ RoleAddressDialog::RoleAddressDialog(QWidget *parent)
line->setCompleter(completer);
connect(line, &QLineEdit::editingFinished, this, [line, s = std::move(s)] {
QStringList list = s;
list.removeAll(line->text());
list.insert(0, line->text());
QString text = line->text();
list.removeAll(text);
list.insert(0, text);
if(list.size() > 10)
list.removeLast();
s.clear(); // Uses on Windows MULTI_STRING registry
Expand Down