Skip to content

Conversation

@rajeshgangireddy
Copy link
Contributor

📝 Description

Some parts of documentation was not updated when we added new models (like Dinomaly and Uninet) and some datasets (like 3DADAM).
In this PR, make sure documentation is up to date with all the models and datasets we have in Anomalib.

Select what type of change your PR is:

  • 🚀 New feature (non-breaking change which adds functionality)
  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🔄 Refactor (non-breaking change which refactors the code base)
  • ⚡ Performance improvements
  • 🎨 Style changes (code style/formatting)
  • 🧪 Tests (adding/modifying tests)
  • 📚 Documentation update
  • 📦 Build system changes
  • 🚧 CI/CD configuration
  • 🔧 Chore (general maintenance)
  • 🔒 Security update
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)

✅ Checklist

Before you submit your pull request, please make sure you have completed the following steps:

  • 📚 I have made the necessary updates to the documentation (if applicable).
  • 🧪 I have written tests that support my changes and prove that my fix is effective or my feature works (if applicable).
  • 🏷️ My PR title follows conventional commit format.

For more information about code review checklists, see the Code Review Checklist.

Copilot AI review requested due to automatic review settings December 2, 2025 14:36
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the documentation to include recently added models (Dinomaly, UniNet, and Fuvas) and datasets (MPDD and 3DADAM) that were missing from various documentation files. Additionally, it includes implementation changes to the Dinomaly model to fix visualization alignment issues when center cropping is used.

Key Changes:

  • Added documentation entries for Dinomaly and UniNet image models, and Fuvas video model
  • Added documentation for MPDD (image) and ADAM 3D (depth) datasets
  • Enhanced metrics documentation with comprehensive descriptions
  • Implemented anomaly map "uncropping" in Dinomaly to align visualizations with pre-crop dimensions

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/anomalib/models/video/init.py Added Fuvas model to module docstring
src/anomalib/models/image/dinomaly/torch_model.py Implemented _uncrop_anomaly_map method and updated forward pass to handle center crop offset for visualization alignment
src/anomalib/models/image/dinomaly/lightning_model.py Updated docstring to clarify preprocessing pipeline (448→392 crop)
src/anomalib/models/image/init.py Added Dinomaly and UniNet to module docstring
src/anomalib/models/init.py Added Dinomaly, UniNet, and Fuvas to main models module docstring
docs/source/markdown/guides/reference/models/video/index.md Added Fuvas card and toctree entry
docs/source/markdown/guides/reference/models/video/fuvas.md Created new documentation page for Fuvas model
docs/source/markdown/guides/reference/models/image/index.md Added Dinomaly and UniNet cards and toctree entries
docs/source/markdown/guides/reference/metrics/index.md Expanded metrics documentation with detailed descriptions and grid layout
docs/source/markdown/guides/reference/data/datamodules/image/mpdd.md Created new documentation page for MPDD dataset
docs/source/markdown/guides/reference/data/datamodules/image.md Added MPDD card and automodule entry
docs/source/markdown/guides/reference/data/datamodules/depth/index.md Added ADAM 3D card and toctree entry
docs/source/markdown/guides/reference/data/datamodules/depth/adam_3d.md Created new documentation page for ADAM 3D dataset

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@rajeshgangireddy
Copy link
Contributor Author

rajeshgangireddy commented Dec 2, 2025

Has some commits unrelated to title. Closing. Will reopen without those commits

Copy link
Contributor

@ashwinvaidya17 ashwinvaidya17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the efforts

@ashwinvaidya17 ashwinvaidya17 merged commit 469dfe4 into open-edge-platform:main Dec 3, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants