Repository navigation
Conversation
🚀 Deploying Preview to Cloudflare 🚀Preview Deployments by commit
View all previews: View all previews ↗ |
comark-annotate
comark-carousel
comark-charts
comark-embed
comark-github-callouts
comark-include
comark-lint
comark-tabs
comark-zoom
commit: |
Next step CI reconciliation completed; the same-head repair budget is exhausted. Final answersSession CI reconciliation completed; the same-head repair budget is exhausted. Session CI reconciliation completed; the same-head repair budget is exhausted. Verified the expected HEAD and all review threads. No code repair is needed. E2E is an external service failure, and the Cloudflare check is unsupported without logs; both require hosted reruns. Session Fixed the required formatting failure in docs/nuxt.config.ts and pushed repair commit 16626cd. Existing code/icon review feedback is resolved. E2E failures include unavailable Playwright download DNS errors and remain for current-head CI verification; Cloudflare Workers failure is unsupported external evidence. Session Fixed the required formatting failure in docs/nuxt.config.ts and pushed repair commit 16626cd. Existing code/icon review feedback is resolved. E2E failures include unavailable Playwright download DNS errors and remain for current-head CI verification; Cloudflare Workers failure is unsupported external evidence. Session Fixed the required formatting failure in docs/nuxt.config.ts and pushed repair commit 16626cd. Existing code/icon review feedback is resolved. E2E failures include unavailable Playwright download DNS errors and remain for current-head CI verification; Cloudflare Workers failure is unsupported external evidence. Session Fixed the required formatting failure in docs/nuxt.config.ts and pushed repair commit 16626cd. Existing code/icon review feedback is resolved. E2E failures include unavailable Playwright download DNS errors and remain for current-head CI verification; Cloudflare Workers failure is unsupported external evidence. Session Fixed the required formatting failure in docs/nuxt.config.ts and pushed repair commit 16626cd. Existing code/icon review feedback is resolved. E2E failures include unavailable Playwright download DNS errors and remain for current-head CI verification; Cloudflare Workers failure is unsupported external evidence. |
…nnested The Nuxt site never registered comark-charts, so its page showed bare tables. A chart, a link card, or a diff no longer sits in a second frame, and the charts styles reach only the chart's own SVG, so a mark's arrow and circle keep their size.
…="none" The box around a marked point grows to fit a circle, so with nothing drawn the arrow stopped about 20px short. A bare mark now keeps its box tight to the point.
|
i think this is unblocked, please @vitehub-bot conflict solve merge and continue |
![pullfrog[bot]](https://avatars.githubusercontent.com/in/1768019?s=60&v=4){kind=small}
There was a problem hiding this comment.
Important
This PR leaves the deployed site pointed at the wrong static output directory and removes the charts Agent Skill from discovery. Both should be fixed before merging.
Reviewed changes
- Nuxt content migration Replaced the handwritten docs builder with Nuxt 5,
@vite-hub/content, a server-rendered page body, and client-side navigation/runtime reinitialization. - Static generation and checks Added Nuxt generation, docs typechecking, a generated-site E2E server, and the associated workspace configuration.
- Runtime adjustment Relaxed annotate's native context-menu geometry check so late layout updates still hand off the best available image.
gpt-5.6-sol ｜ 𝕏
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
- Completed deployment alignment Pointed Wrangler and the static E2E server at Nitro's
docs/dist/publicoutput root and added the generated asset MIME types. - Restored skill discovery Copied both
comark-annotateandcomark-chartsinto the legacy and Agent Skills discovery paths and generated both index entries. - Removed the obsolete builder Deleted the conflicting handwritten docs builder so
docs:builduses Nuxt generation, while docs typechecking remains part ofcheck. - Relaxed context-menu handoff Kept the prepared annotate copy as the fallback when late layout changes invalidate its geometry key.
gpt-5.6-sol ｜ 𝕏
onmax/comark-plugins#45 sets blockExoticSubdeps: false, so the host refused every install and its passes ran without dependencies. The host still installs with --ignore-scripts.
|
Current HEAD d908ef7 fails the required check and e2e jobs during frozen install: pnpm reports a missing lockfile entry for the fontsource-variable caveat package version 5.3.0 (P1 broken lockfile). The repair window currently forbids edits and pushes, so this remains for the next pass. |
|
Verified current HEAD afcf6a7. Required |
|
use latest pkg.pr.new which i think ahas been updated. just to test :) |
There was a problem hiding this comment.
Important
The merged docs pages currently render without the comark-code and comark-icon integrations, so the new /code/ and /icon/ documentation examples do not demonstrate the behavior they document.
Reviewed changes
- Merged current docs content Incorporated the
comark-code,comark-icon, andlint-comarkchanges frommaininto the Nuxt migration. - Repaired dependency metadata Restored the missing workspace packages and lockfile snapshots needed by the merged workspace state.
gpt-5.6-sol ｜ 𝕏
|
Verified against current HEAD 98fccd7: the comark-code and comark-icon integrations are still absent from docs/server/content.ts, the renderer component map, and docs/package.json. This is a valid P1 because /code/ and /icon/ lose documented behavior. The repair window is closed, so I cannot edit or push in this pass; it remains for the next repair pass. |
|
Verified current HEAD 98fccd7: |
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
- Corrected the tabs lockfile importer Moved
comark-iconfromdevDependenciestodependenciesforpackages/tabs, matching the package manifest and preserving the runtime dependency in clean installs.
gpt-5.6-sol ｜ 𝕏
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
- Registered code and icon integrations Added
comark-codeandcomark-iconto the docs workspace dependencies, Markdown plugin pipeline, and HTML renderer component map so the merged documentation pages retain their documented behavior. - Reconciled lockfile metadata Restored the corresponding workspace importer entries and normalized the affected lockfile records without introducing source or runtime changes.
gpt-5.6-sol ｜ 𝕏
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
- Repinned the Vite Hub preview Updated
@vite-hub/contentand its transitive preview packages fromf808e9ctob8398fb. - Refreshed lockfile integrity data Replaced the affected tarball URLs, integrity hashes, and dependency references without changing the Nuxt source or deployment configuration.
gpt-5.6-sol ｜ 𝕏
There was a problem hiding this comment.
Important
This commit makes clean installs fail because Nuxt preparation copies a playground directory that does not exist until a later build step.
Reviewed changes
- Preserved the playground Added the generated legacy playground output to Nuxt's public asset set and changed
docs:buildto run the legacy builder before Nuxt generation.
gpt-5.6-sol ｜ 𝕏
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
This incremental review covered the playground-preparation fix since the prior Pullfrog review, along with the complete PR diff for context.
- Guarded optional playground copying Made the Nuxt asset preparation tolerate a missing prebuilt
docs/dist/play/directory while still copying it when the legacy build has produced it. - Added the docs image command Restored the root
docs:imagesscript in the current workspace configuration.
gpt-5.6-sol ｜ 𝕏
|
Current HEAD 16626cd passes local Nuxt generation after building workspace packages, and formatting is clean. The hosted e2e failure is not reproducible locally; its log includes Playwright download DNS failures (ENOTFOUND playwright.download.prss.microsoft.com) and broad timeouts, while exact-base e2e passes. Please rerun the e2e workflow after the Playwright download service recovers. |
This branch has not been deployed
1 participant
Draft. This is the spike for moving the docs site from
docs/build.tsto Nuxt 5 and@vite-hub/content, for review. Don't merge it:build.tsstill builds and deploys the site, and the switch-over steps below aren't done.What it is
docs/becomes a Nuxt app pinned tonuxt-nightly@5.0.0-2610192007-fe9ca5b. It readsdocs/pages/*.mdthrough@vite-hub/content(pkg.pr.new, pinned to commitf808e9c), with the workspace plugins inmarkdown.plugins.server/api/pages/[...slug].get.tsports the rendering frombuild.ts:example,examples,plugins, nav, and front matter. A page with plugin issues failsnuxi generate, the same asbuild.ts.PageBody.server.vue). The HTML reaches the browser once: in the page on a first load, or as island JSON on a client-side navigation.v-htmlin a normal component also put the body in the payload and doubled/annotate/to 470 KB.<script>s, soapp/utils/scripts.tsre-runs the inlined zoom, carousel, annotate, and tabs scripts when an island brings them. Each script ref-counts its callers, so running it again is harmless.docs/pages, the URLs,.well-known/agent-skills/*and.well-known/skills/*, anddocs/worker.tsdon't change.blockExoticSubdeps: false(the@vite-hub/*previews depend on each other by URL, and pnpm 11 has no per-package exception),allowBuilds: { esbuild: false }, and the nightly release-age exclusions. The roottsconfig.jsonexcludes the Nuxt sources;vue-tscchecks them throughdocs/tsconfig.json.mainportscomark-tabs(feat(tabs): add comark-tabs, tabs and code groups that read without a script and sync by label #37) and thetabs→examplesrename.Checks
pnpm readypasses: 169 tests and every Doctor run, includingdoctor.config.tsoverdocs/pages.pnpm --filter comark-plugins-docs generateprerenders 31 routes, including/tabs/.pnpm --filter comark-plugins-docs typecheck(vue-tsc) passes.docs/.output/publicpasses 37 of 37./to/tabs/(click and arrow keys), then to/annotate/(zoom opens and closes on Escape), then Back to/tabs/, with no console errors, and checks that the window persists, so each step is a client-side navigation.wrangler deploy --dry-runwithdocs/worker.tsand the Nuxt output passed.build.ts/annotate/HTMLBefore this can merge
feat/charts(feat(charts): add comark-charts, charts drawn from Markdown tables that agents read as data #44) anddocs/restructure. The page list should come from the content source instead ofshared/pages.ts, and/guide/*needs nested slugs.docs/dist, givee2e/serve.tsthe.js,.css, and.jsontypes, makedocs:buildrungenerate, then deletebuild.ts.vue-tsccheck topnpm check.pluginswere silently dropped) and feat(content)!: install Workspace and Database only for collections vite-hub/vitehub#2668 (installs 58 packages instead of 203). After they merge, move the pin to that commit or an npm release, and dropblockExoticSubdeps: falseonce@vite-hub/*is on npm.The lockfile diff is mostly peer-context re-keys: the spike added 375 packages and changed none of the existing ones.
🤖 Generated with Claude Code