Skip to content

accounts: honor configured hash algorithm on Google KMS signer #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
vishalchangrani wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

accounts: honor configured hash algorithm on Google KMS signer #233

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion accounts/keys.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,9 +163,13 @@
return nil, err
}

accountKMSSigner, err := kmsClient.SignerForKey(
// Honor the hash algorithm declared in flow.json. GCP KMS only supports SHA2_256
// natively for its EC_SIGN_P256_SHA256 key type, so if the on-chain key is
// registered with SHA3_256 we need to pre-hash client-side and submit the digest.
accountKMSSigner, err := kmsClient.SignerForKeyWithHashAlgo(

Check failure on line 169 in accounts/keys.go

View workflow job for this annotation

GitHub Actions / test 

kmsClient.SignerForKeyWithHashAlgo undefined (type *cloudkms.Client has no field or method SignerForKeyWithHashAlgo)

Check failure on line 169 in accounts/keys.go

View workflow job for this annotation

GitHub Actions / lint 

kmsClient.SignerForKeyWithHashAlgo undefined (type *cloudkms.Client has no field or method SignerForKeyWithHashAlgo) (typecheck)
ctx,
a.kmsKey,
a.HashAlgo(),
)
if err != nil {
return nil, err
Expand Down
Loading