Open
Conversation
mts1715
reviewed
Apr 1, 2026
| // | ||
| // In this test, the topUpSource behavior is adversarial: it attempts to re-enter | ||
| // the pool during the pull/deposit flow. We expect the transaction to fail. | ||
| let withdrawRes = _executeTransaction( |
Contributor
There was a problem hiding this comment.
Suggested change
| let withdrawRes = _executeTransaction( | |
| let withdrawRes = _executeTransaction( |
mts1715
reviewed
Apr 1, 2026
| vaultPublicPath: FLOW_VAULT_PUBLIC_PATH | ||
| ) ?? 0.0 | ||
| Test.assertEqual(FLOWBefore, FLOWAfter) | ||
| } No newline at end of file |
mts1715
reviewed
Apr 1, 2026
| access(contract) var uniqueID: DeFiActions.UniqueIdentifier? | ||
| /// An unentitled Capability on the Vault to which deposits are distributed | ||
| access(self) let depositVault: Capability<&{FungibleToken.Vault}> | ||
| access(all) let liveDataCap: Capability<&LiveData> |
mts1715
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #282
Context
This PR adds the remaining missing tests from the issue, with a primary focus on
reentrancy scenarios in DeFi actions.Notes:
cadence/tests/adversarial_recursive_withdraw_source_test.cdcwas renamed tocadence/tests/adversarial_reentrancy_test.cdcAll other relevant tests already exist or are covered in PR: Rebalancing Failures #290
Flash Loan tests not included as it is a part from
FutureFeatures(https://github.com/onflow/FlowALP/blob/main/FutureFeatures.md#10--flash-loan-support)