feat: add ACTIVITY to ScreenType enum for RN activity screen#2646
Open
lealobanov wants to merge 11 commits intodevfrom
Open
feat: add ACTIVITY to ScreenType enum for RN activity screen#2646lealobanov wants to merge 11 commits intodevfrom
lealobanov wants to merge 11 commits intodevfrom
Conversation
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Add ACTIVITY screen type handling in ReactNativeActivity - Replace native TransactionRecordFragment with RN Activity screen - Update MainContentPresenter to launch ReactNativeActivity for Activity tab Closes #1194
Remove native Android Activity/Transaction Record screen as it's now replaced by React Native Activity screen. Deleted files: - TransactionRecordActivity, Fragment, ViewModel - TransactionRecordListAdapter - TransactionRecord and TransactionViewMoreModel - All related presenters (5 files) - Layout XML files (3 files) Updated: - AndroidManifest.xml: removed activity declaration - MainPageAdapter.kt: reduced page count to 4 - TokenDetailActivitiesPresenter.kt: use RN Activity screen - Utils.kt: removed toTransactionRecord() function Closes #1194
Add placeholder implementations for createSeedKey, saveNewKey, removeOldKey, and signRotationRequest to fix build error. These methods are defined in the TypeScript bridge spec but were not implemented in Android. Full implementation needed for key rotation feature.
- Create ReactNativeActivityFragment to host RN Activity screen - Update MainPageAdapter to include Activity fragment at position 4 - Update MainContentPresenter to use ViewPager navigation for Activity tab - This keeps bottom navigation visible when viewing Activity screen Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Pass the native app's dark mode state to React Native so the embedded Activity screen uses the correct theme colors. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes #???
Summary of Changes
Need Regression Testing
Risk Assessment
Additional Notes
Screenshots (if applicable)