Skip to content

[matrix_mul] Better argument checking for static code checker #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrewtbarker merged 1 commit into from
Apr 29, 2026
Merged

[matrix_mul] Better argument checking for static code checker #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion matrix_mul_mkl/matrix_mul_mkl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,7 @@ void device_info(sycl::device const& D) {

int main(int argc, char **argv)
{
constexpr int max_dim = 1000000;
auto pname = argv[0];
int M = 4096, N = 4096, K = 4096;
std::string type = "none";
Expand All @@ -183,7 +184,7 @@ int main(int argc, char **argv)
K = std::atoi(argv[3]);
}

if (M <= 0 || N <= 0 || K <= 0)
if (M <= 0 || N <= 0 || K <= 0 || M > max_dim || N > max_dim || K > max_dim)
usage(pname);

bool g_success = true;
Expand Down