Conversation
Add python bindings, unit tests, black box test coverage and README entries for: 1. zesDriverEnumInfoLogsExt 2. zesInfoLogGetPropertiesExt 3. zesInfoLogCreateInstanceExt 4. zesInfoLogInstanceReadWithMetadataExt 5. zesInfoLogInstancePeekWithMetadataExt 6. zesInfoLogInstanceDeleteExt Related-To: SYSM-432 Signed-off-by: Aviral Nigam <aviral.nigam@intel.com>
aviralni
force-pushed
the
pyzes_infolog
branch
from
September 23, 2026 06:03
796e835 to
fbd1a41
Compare
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Test failures are not propagated, warning results are mishandled, and the documented package version is inconsistent.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 3
Open (4)
What changed in this PR
Adds Python Sysman bindings and validation coverage for Info Log APIs.
Changes:
- Adds Info Log handles, enums, structures, and API wrappers.
- Adds unit and black-box tests.
- Documents supported Info Log APIs.
| File | Description |
|---|---|
pyzes.py |
Adds Info Log bindings. |
test_info_log.py |
Adds wrapper unit tests. |
pyzes_black_box_test.py |
Adds Info Log runtime tests and CLI option. |
README.md |
Documents API support. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+948
to
+951
| if check_rc(f"zesInfoLogInstanceReadWithMetadataExt(info log {i}, query)", rc): | ||
| print_verbose( | ||
| f" Read Query: {record_count.value} record(s), {size.value} bytes" | ||
| ) |
| test_engine_modules(devices[device_idx], device_idx) | ||
|
|
||
| # Test info logs (driver scoped) | ||
| test_info_log_module(drivers[driver_idx], driver_idx) |
| # Info logs are driver scoped, so run them once per driver | ||
| if args.infolog: | ||
| for driver_idx in range(driver_count): | ||
| test_info_log_module(drivers[driver_idx], driver_idx) |
Comment on lines
+199
to
+204
| | `zesDriverEnumInfoLogsExt` | Info Log | 0.1.3 | None | | ||
| | `zesInfoLogGetPropertiesExt` | Info Log | 0.1.3 | None | | ||
| | `zesInfoLogCreateInstanceExt` | Info Log | 0.1.3 | None | | ||
| | `zesInfoLogInstanceReadWithMetadataExt` | Info Log | 0.1.3 | Records returned are consumed | | ||
| | `zesInfoLogInstancePeekWithMetadataExt` | Info Log | 0.1.3 | Requires `isPeekDataSupported` | | ||
| | `zesInfoLogInstanceDeleteExt` | Info Log | 0.1.3 | None | |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.