Add PHP 8.5 compatibility#14
Open
lopadova wants to merge 1 commit into
Open
Conversation
Author
|
CI passed on the source fork branch: https://github.com/padosoft/php-sdk/actions/runs/26479078644 The original repository currently reports no PR checks for this cross-repo branch, so the passing fork run is linked here for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
php >=5.4while removing PHP 8.5 deprecations from nullable class/scalar parameters.Analytics, provider helpers,User::publish, legacyStorage::updateUserargument order).Validation
composer validate --strict --no-check-lockcomposer teston PHP 8.4php85 -d extension_dir=C:\Users\lopad\.config\herd\bin\php85\ext -d extension=php_mbstring.dll vendor\bin\phpunitsrc/**/*.phpgit diff --checkNote: local PHP 8.5 required explicit
mbstringloading because the local Herd PHP 8.5 CLI has that extension disabled by default. PHP 5.4 source lint is covered in CI viashivammathur/setup-php, which documents PHP 5.4 support on GitHub-hosted runners.