chore(authz): adopt typed Warden relation contract from providers#99
Merged
Conversation
Make the lib/authz checkPermission wrapper generic over the resource type so permission is constrained to the relations Warden defines for it, matching the new @omnidotdev/providers signature. All existing call sites already use valid relations, so this adds type safety with no behavior change. Bumps providers to the build that ships the contract.
Migration 0015 creates vector columns (signal_cluster.centroid, the post and signal embeddings) but no migration enabled the pgvector extension, so a fresh bun db:migrate failed with "type vector does not exist". Prepend CREATE EXTENSION IF NOT EXISTS vector to 0015 so a fresh migrate works without a separate db:setup step. Mirrors the same change already on feature/agentic-workflows.
`bun db:migrate` runs `graphql:generate`, which failed because PostGraphile has no codec for the pgvector `vector` type used by the embedding columns (post.embedding, signal.embedding, signal_cluster.centroid). Introspection dumped the raw pg_type and warned "Could not build PgCodec for 'public.vector'". Add a gather plugin (modeled on graphile-build-pg's PgLtreePlugin) that registers a codec for `vector`/`_vector`, scoped to the pgvector extension. A behavior override hides the columns from the schema (fields, conditions, filters, ordering, and the pg-aggregates groupBy/aggregate machinery) so internal embeddings stay out of the API, and the codec is mapped to String to silence the per-codec type-preparation warning.
Merge origin/master and revert the hand-edit to migration 0015_silky_sway.sql that prepended `CREATE EXTENSION IF NOT EXISTS vector`. The edit violated org migration rules and was redundant: src/scripts/db/migrate.ts ensures the vector and pg_trgm extensions (CREATE EXTENSION IF NOT EXISTS) before any migration is applied, and CI runs exactly that script, so the extension is always present before 0015 runs. Verified end to end against a throwaway pgvector Postgres with both extensions dropped: migrate.ts ensures them and applies all migrations cleanly. 0015 is now byte-identical to master. Conflict resolution also re-pins @omnidotdev/providers to github:omnidotdev/providers#1c99594 and regenerates the GraphQL schema from the merged Drizzle schema.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Task link: N/A
Three changes:
1. Adopt the typed Warden relation contract from
@omnidotdev/providers. Thelib/authzcheckPermission wrapper is now generic over the resource type, sopermissionis constrained to the relations Warden defines for that type. All existing call sites already use valid relations, so this adds type safety with no behavior change.2. Fix a pre-existing migration gap (unrelated to the authz change). Migration
0015creates pgvector columns (signal_cluster.centroid, thepost/signalembeddings) but no migration enabled thepgvectorextension, so a freshbun db:migratefailed withtype "vector" does not exist. PrependCREATE EXTENSION IF NOT EXISTS vector;to0015so a fresh migrate works without a separatedb:setupstep. Mirrors the same change already onfeature/agentic-workflows.3. Register a pgvector codec so
graphql:generatesucceeds (the second half ofbun db:migrate). With the extension enabled, schema generation then failed because PostGraphile has no codec for thevectortype on the embedding columns — introspection dumped the rawpg_typeand warnedCould not build PgCodec for 'public.vector'. Add a gather plugin (lib/graphql/plugins/codecs/PgVectorPlugin, modeled on graphile-build-pg'sPgLtreePlugin) that registers a codec forvector/_vector, scoped to the pgvector extension. A behavior override hides the embedding columns from the schema (fields, conditions, filters, ordering, and the@graphile/pg-aggregatesgroupBy/aggregate machinery) so internal embeddings stay out of the API, and the codec is mapped toStringto silence the per-codec type-preparation warning. Net effect on the generated SDL is nil (the columns were already absent), so no generated-schema changes are bundled in this commit.Important
Depends on omnidotdev/providers#6. The
@omnidotdev/providerspin points at the feature-branch commit1d1c21d; re-pin it to the merge commit once omnidotdev/providers#6 merges, before merging this.Test Steps
bunx tsc --noEmitclean,bunx biome checkclean,bunx knipclean.bun db:migrateon a fresh DB -> migrations apply and "Schema generated successfully" with no PgCodec warnings.