fix(entitlements): unlimited feedback users on free tier to match catalog#100
Merged
Conversation
…alog
The local DEFAULT_LIMITS fallback (used when an org has no Aether billing
record) capped max_feedback_users at 15 for the free tier, contradicting the
product catalog SSOT, which sets it to -1 (unlimited) on every backfeed tier,
and the marketing copy ("Unlimited feedback submissions"). Any org not yet
provisioned in Aether silently hit a 15-unique-user cap per project.
Set the fallback to -1 to mirror the catalog. Removing a cap cannot regress
existing users.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The local
DEFAULT_LIMITSfallback (used when an org has no Aether billing record) cappedmax_feedback_usersat 15 for the free tier. This contradicts:omni-apiplanConfigs.ts), which setsmax_feedback_users: -1(unlimited) on every backfeed tier, andAny org not yet provisioned in Aether silently hit a 15-unique-feedback-user cap per project ("Maximum number of unique users providing feedback has been reached").
Fix
Set the fallback
max_feedback_users.freeto-1to mirror the catalog. Removing a cap cannot regress existing users.Notes
DEFAULT_LIMITSalso drift from the catalog (max_projects1 vs 2,max_comments_per_post100 vs 50). Left as-is here to avoid lowering live limits; tracked for separate reconciliation.