test: add authorization service unit tests #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan Zachmann <50990105+JanZachmann@users.noreply.github.com>
Signed-off-by: Jan Zachmann <50990105+JanZachmann@users.noreply.github.com>
Signed-off-by: Jan Zachmann <50990105+JanZachmann@users.noreply.github.com>
- Implemented auth.spec.ts, device.spec.ts, network.spec.ts - Added centrifugo fixture helper - Fixed Centrifugo subscription in App.vue - Improved test scripts for argument forwarding - Configured playwright to ignore HTTPS errors - Added jsonwebtoken for test token generation Signed-off-by: Jan Zachmann <50990105+JanZachmann@users.noreply.github.com>
Add comprehensive unit tests for AuthorizationService covering: - FleetAdministrator role with valid/invalid tenants - FleetOperator role with matching/non-matching fleets - FleetObserver role rejection - Missing claims (roles, tenant_list, fleet_list) handling - Invalid SSO token verification Tests use mockall to mock SingleSignOnProvider and DeviceServiceClient. 12 tests added, bringing total backend tests from 28 to 40. Signed-off-by: Jan Zachmann <50990105+JanZachmann@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add comprehensive unit tests for
AuthorizationServiceto validate role-based access control logic.Tests Added (12)
FleetAdministrator Role
FleetOperator Role
FleetObserver Role
Missing Claims
Token Verification
Implementation Details
mockallto mockSingleSignOnProviderandDeviceServiceClientcreate_claims()for test dataTest Results
cargo test --features mock services::auth::authorization::testsAll 12 tests pass ✅
Impact
Checklist
cargo fmtSigned-off-by: Jan Zachmann 50990105+JanZachmann@users.noreply.github.com