test: add comprehensive authentication state tests (PR 1.1) #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add unit tests for all authentication flows in the Core: - Login: loading state, success/failure handling, error clearing - Logout: session cleanup, error handling - Set password: initial password setup flow - Update password: password change with validation - Check requires password: state management Tests are colocated with the auth handler code following Rust conventions. Signed-off-by: Jan Zachmann <50990105+JanZachmann@users.noreply.github.com>
JanZachmann
force-pushed
the
test/core-auth
branch
from
465c48c to
f576ca7
Compare
Update FRONTEND_TEST_CONCEPT.md to reflect: Phase 1 Complete (92 tests): - PR omnect#77: Authentication Tests (17 tests) - PR omnect#78: Device Tests (27 tests) - PR omnect#79: Network Tests (21 tests) - PR omnect#80: Reconnection Tests (27 tests) Phase 2 Skipped: - Effect emission testing deemed low-value after Phase 1 implementation - Effects are auto-generated and handled by well-tested macros - Testing implementation details (how Core communicates) vs behavior (what it does) - Response handling tests in Phase 1 already validate request/response cycles Lessons Learned: - Colocated tests improve maintainability - Domain organization mirrors code structure - Response-focused testing validates behavior without coupling - Avoid testing auto-generated types and macro usage Key Patterns: - Use `let _ = app.update(...)` for unused results - Test response events not request events - Organize with nested modules - Use helper functions for test data Signed-off-by: Jan Zachmann <50990105+JanZachmann@users.noreply.github.com>
JanZachmann
changed the title
Update FRONTEND_TEST_CONCEPT.md to accurately reflect that this branch (test/core-auth) only contains the authentication tests from PR 1.1. The document previously indicated all of Phase 1 was complete (92 tests across 4 PRs), but this branch only has 17 authentication tests. Changes: - Update Phase 1 status from "Complete (92 tests)" to "In Progress (17 tests)" - Mark PR omnect#77 (Authentication Tests) as complete for this branch - Mark PR omnect#78-80 as pending (not in this branch) - Update ROI Summary table to show correct progress (17/92 tests) - Fix markdown formatting issues (blank lines around lists/headings) Signed-off-by: Jan Zachmann <50990105+JanZachmann@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds comprehensive unit tests for all authentication flows in the Crux Core, following the testing strategy defined in FRONTEND_TEST_CONCEPT.md (Phase 1.1).
Changes
Test Coverage
Architecture
src/app/src/update/auth.rsfollowing Rust conventionscrux_core::testing::AppTesterfor deterministic state testinglogin,logout, etc.)Cleanup
src/app/src/tests.rs(tests now live next to the code they test)lib.rsTest Results
All tests pass with no warnings from clippy.
Signed-off-by: Jan Zachmann 50990105+JanZachmann@users.noreply.github.com