Skip to content

fix to_viewport #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aggroot wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix to_viewport #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions botasaurus_driver/core/element.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -653,6 +653,7 @@ def get_position(self, abs=False):
abs_y = pos.top + scroll_y + (pos.height / 2)
pos.abs_x = abs_x
pos.abs_y = abs_y

return DictPosition(pos)
except IndexError:
pass
Expand Down Expand Up @@ -1247,7 +1248,7 @@ def __repr__(self):

class DictPosition(ContraDict):
def __init__(self, position: _Position):
self._position = position
self._position = position # Stores as list, loses methods & attributes!
if position:
self.left = position.left
self.top = position.top
Expand Down Expand Up @@ -1298,7 +1299,11 @@ def to_dict(self):


def to_viewport(self, scale=1):
return self._position.to_viewport(scale)
# Don't rely on _position which may have lost its type
# Use the values already extracted
return cdp.page.Viewport(
x=self.x, y=self.y, width=self.width, height=self.height, scale=scale
)

def __repr__(self):
return str(self.to_dict())