Skip to content

Conversation

@defistar
Copy link

@defistar defistar commented Jan 21, 2026

Context

OKX-Pay transactions are not to be prioritized over other transactions, the code to perform prioritization conflicts with the upstream code ethereum-optimism/op-geth

Reason:

  1. okx/geth performance is good enough to seal all transactions in a block at current tx volume
  2. easy sync with upstream with out any code-conflicts

Change List:

  • removed tests for OKPay

Tests:

devnet % make run-geth-test
Setting up op-geth dependencies...
Using op-geth from: /Users/lakshmikanth/Documents/xlayer/op-geth
Switching to branch: feat/remove-okpay-priority
Already on 'feat/remove-okpay-priority'
Your branch is up to date with 'origin/feat/remove-okpay-priority'.
From github.com:okx/op-geth
 * branch                feat/remove-okpay-priority -> FETCH_HEAD
Already up to date.
Updating go.mod...
go.mod configured successfully

Replace directive: github.com/ethereum/go-ethereum => /Users/lakshmikanth/Documents/xlayer/op-geth
Running Geth E2E tests...
=== RUN   TestSendTx
--- PASS: TestSendTx (4.02s)
=== RUN   TestChainID
chainID from geth chain is 195
--- PASS: TestChainID (0.00s)
=== RUN   TestEthTransfer
--- PASS: TestEthTransfer (2.00s)
=== RUN   TestDebugTraceRPC
=== RUN   TestDebugTraceRPC/DebugTraceBlockByHash
=== RUN   TestDebugTraceRPC/DebugTraceBlockByNumber
=== RUN   TestDebugTraceRPC/DebugTraceTransaction
--- PASS: TestDebugTraceRPC (0.02s)
    --- PASS: TestDebugTraceRPC/DebugTraceBlockByHash (0.01s)
    --- PASS: TestDebugTraceRPC/DebugTraceBlockByNumber (0.00s)
    --- PASS: TestDebugTraceRPC/DebugTraceTransaction (0.00s)
=== RUN   TestEthereumBasicRPC
Block number: 8596467, attempt: 0Block data type: map[string]interface {}
Extracted block hash: 0x49c8c912c5c3dfa01419251c0c0b417333a5f2a16944fa93d109263fbdb357c8
=== RUN   TestEthereumBasicRPC/EthChainID
=== RUN   TestEthereumBasicRPC/EthSyncing
=== RUN   TestEthereumBasicRPC/EthGetBalance
=== RUN   TestEthereumBasicRPC/EthGetCode
=== RUN   TestEthereumBasicRPC/EthGetTransactionCount
=== RUN   TestEthereumBasicRPC/EthBlockNumber
=== RUN   TestEthereumBasicRPC/EthGasPrice
=== RUN   TestEthereumBasicRPC/EthGetStorageAt
--- PASS: TestEthereumBasicRPC (0.01s)
    --- PASS: TestEthereumBasicRPC/EthChainID (0.00s)
    --- PASS: TestEthereumBasicRPC/EthSyncing (0.00s)
    --- PASS: TestEthereumBasicRPC/EthGetBalance (0.00s)
    --- PASS: TestEthereumBasicRPC/EthGetCode (0.00s)
    --- PASS: TestEthereumBasicRPC/EthGetTransactionCount (0.00s)
    --- PASS: TestEthereumBasicRPC/EthBlockNumber (0.00s)
    --- PASS: TestEthereumBasicRPC/EthGasPrice (0.00s)
    --- PASS: TestEthereumBasicRPC/EthGetStorageAt (0.00s)
=== RUN   TestEthereumBlockRPC
ContractAAddr: 0x95a5AdDB9CD750e0816414DFD3Fb67d8e8216126
ContractBAddr: 0xC7dCc636733192aA1160dF0Dca96FDABc8849527
Block number: 8596481, attempt: 0Block data type: map[string]interface {}
Extracted block hash: 0xbf1175eae2b33f8ee701629680ef0f4f0ba876fbbc7d70077325b508ba49370f
=== RUN   TestEthereumBlockRPC/EthGetBlockByHash
=== RUN   TestEthereumBlockRPC/EthGetBlockByNumber
=== RUN   TestEthereumBlockRPC/EthGetBlockTransactionCountByHash
=== RUN   TestEthereumBlockRPC/EthGetBlockTransactionCountByNumber
=== RUN   TestEthereumBlockRPC/EthGetTransactionByBlockHashAndIndex
=== RUN   TestEthereumBlockRPC/EthGetTransactionByBlockNumberAndIndex
=== RUN   TestEthereumBlockRPC/EthGetBlockReceipts
All 10 transactions have been mined successfully
--- PASS: TestEthereumBlockRPC (16.09s)
    --- PASS: TestEthereumBlockRPC/EthGetBlockByHash (0.00s)
    --- PASS: TestEthereumBlockRPC/EthGetBlockByNumber (0.00s)
    --- PASS: TestEthereumBlockRPC/EthGetBlockTransactionCountByHash (0.00s)
    --- PASS: TestEthereumBlockRPC/EthGetBlockTransactionCountByNumber (0.00s)
    --- PASS: TestEthereumBlockRPC/EthGetTransactionByBlockHashAndIndex (0.00s)
    --- PASS: TestEthereumBlockRPC/EthGetTransactionByBlockNumberAndIndex (0.00s)
    --- PASS: TestEthereumBlockRPC/EthGetBlockReceipts (2.03s)
=== RUN   TestEthereumTransactionRPC
TransToken txhash: 0xfa6c08d45d62b2640462f28d772a22fb2fa4735c8fded4f96f48dfa16cf778df
=== RUN   TestEthereumTransactionRPC/EthEstimateGas
=== RUN   TestEthereumTransactionRPC/EthEstimateGas/SimpleTransfer
EthEstimateGas SimpleTransfer result: 21000 gas
=== RUN   TestEthereumTransactionRPC/EthEstimateGas/ContractCall
EthEstimateGas ContractCall result: 71724 gas
=== RUN   TestEthereumTransactionRPC/EthCall
=== RUN   TestEthereumTransactionRPC/EthGetTransactionByHash
=== RUN   TestEthereumTransactionRPC/EthGetTransactionReceipt
--- PASS: TestEthereumTransactionRPC (2.02s)
    --- PASS: TestEthereumTransactionRPC/EthEstimateGas (0.00s)
        --- PASS: TestEthereumTransactionRPC/EthEstimateGas/SimpleTransfer (0.00s)
        --- PASS: TestEthereumTransactionRPC/EthEstimateGas/ContractCall (0.00s)
    --- PASS: TestEthereumTransactionRPC/EthCall (0.00s)
    --- PASS: TestEthereumTransactionRPC/EthGetTransactionByHash (0.00s)
    --- PASS: TestEthereumTransactionRPC/EthGetTransactionReceipt (0.00s)
=== RUN   TestEthereumLogsRPC
Block number: 8596485, attempt: 0Block data type: map[string]interface {}
Extracted block hash: 0x2872e19c825dd15d0ffe3bc93644a4f8e7fcaa61d96a1b1f67b3a0cc0d0b4bbb
=== RUN   TestEthereumLogsRPC/EthGetLogs
--- PASS: TestEthereumLogsRPC (0.00s)
    --- PASS: TestEthereumLogsRPC/EthGetLogs (0.00s)
=== RUN   TestTxPoolRPC
Block number: 8596485, attempt: 0Block data type: map[string]interface {}
Extracted block hash: 0x2872e19c825dd15d0ffe3bc93644a4f8e7fcaa61d96a1b1f67b3a0cc0d0b4bbb
=== RUN   TestTxPoolRPC/TxPoolContent
=== RUN   TestTxPoolRPC/TxPoolStatus
--- PASS: TestTxPoolRPC (0.00s)
    --- PASS: TestTxPoolRPC/TxPoolContent (0.00s)
    --- PASS: TestTxPoolRPC/TxPoolStatus (0.00s)
=== RUN   TestInnerTx
signedContractCSetValueTxHash: 0xd52fd13abb3b18ed6b913b4f952413e33d4de9c49a53bcbced4710d295c3f07a
=== RUN   TestInnerTx/GetInternalTransactions
    smoke_test.go:585: 
                Error Trace:   xlayer/xlayer-toolkit/devnet/op-geth/test/e2e/smoke_test.go:585
                Error:          Received unexpected error:
                                unsupported internal transaction method
                Test:           TestInnerTx/GetInternalTransactions
--- FAIL: TestInnerTx (6.02s)
    --- FAIL: TestInnerTx/GetInternalTransactions (0.00s)
FAIL
FAIL    github.com/okx/op-geth/test/e2e 30.545s
FAIL
make: *** [run-geth-test] Error 1

@defistar defistar self-assigned this Jan 21, 2026
@defistar defistar added the enhancement New feature or request label Jan 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants