Skip to content

Fix: Return Success=false for cancelled operations#9

Merged
oising merged 2 commits intoaspirifyfrom
copilot/sub-pr-8
Feb 9, 2026
Merged

Fix: Return Success=false for cancelled operations#9
oising merged 2 commits intoaspirifyfrom
copilot/sub-pr-8

Conversation

Copy link

Copilot AI commented Feb 9, 2026

When users cancel form inputs or command arguments, the code was returning Success = true with an error message—semantically contradictory since ProjectCommanderHub nullifies error messages when Success = true (line 67):

annotation.ErrorMessage = success ? null : errorMessage;

Changes

  • Startup form cancellation (line 127): Success = trueSuccess = false
  • Command argument cancellation (line 246): Success = trueSuccess = false

Aligns cancellation handling with other error conditions throughout the codebase that correctly return Success = false.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: oising <1844001+oising@users.noreply.github.com>
Copilot AI changed the title [WIP] Address feedback on project-defined startup forms and commands Fix: Return Success=false for cancelled operations Feb 9, 2026
Copilot AI requested a review from oising February 9, 2026 18:51
@oising oising marked this pull request as ready for review February 9, 2026 19:11
Copilot AI review requested due to automatic review settings February 9, 2026 19:11
@oising oising merged commit 275e6a1 into aspirify Feb 9, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants