Fix: Return Success=false for cancelled operations#9
Merged
Conversation
Co-authored-by: oising <1844001+oising@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback on project-defined startup forms and commands
Fix: Return Success=false for cancelled operations
Feb 9, 2026
oising
approved these changes
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When users cancel form inputs or command arguments, the code was returning
Success = truewith an error message—semantically contradictory sinceProjectCommanderHubnullifies error messages whenSuccess = true(line 67):Changes
Success = true→Success = falseSuccess = true→Success = falseAligns cancellation handling with other error conditions throughout the codebase that correctly return
Success = false.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.