Skip to content

Conversation

@kapeels
Copy link
Member

@kapeels kapeels commented Apr 28, 2017

This is to allow client applications to have a numeric id associated with a user account.

To be used by the pam_ohmage module. This is one of the solutions to pam_ohmage #3.

However, I am not sure if ohmage should be doing this. I cannot see how this change would break anything within ohmage or any of the existing client application.

Is there a reason ohmage did not return the numeric user ids?

@kapeels
Copy link
Member Author

kapeels commented Apr 28, 2017

@stevenolen Would love your thoughts on this.

This is all experimental!

@kapeels kapeels requested a review from stevenolen April 28, 2017 02:15
Copy link
Member

@stevenolen stevenolen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

finally had a chance to take a look! this is a pretty slick way of accomplishing the task you're looking to do.

I'd suggest implementing one extra layer on top of this -- a config param that is disabled by default to return the extra field only if true, mainly since you're returning an existing user value and it can't be known definitively how others are using said value. maybe something like return_user_id=true?

Happy to see a more stable workaround!

@kapeels
Copy link
Member Author

kapeels commented May 18, 2017

The config param's a great idea - it'd keep any clients from breaking. Thanks, Steve!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants